gerritbot added a comment.
Change 358963 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Reword Echo notification text
https://gerrit.wikimedia.org/r/358963TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL
Ladsgroup added a comment.
I was able to build a live test setup. It's redis-dispatching-repo.wmflabs.org and redis-dispatching-client.wmflabs.org. I applied my patch and the result is like this:
F8460077: image.png
It looks nice.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL
Lydia_Pintscher added a comment.
@jmatazzoni Ahh! Now I get what you mean. Good point. Amir already made that change in the patch. Thanks.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 358963 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] [WIP] Reword Echo notification text
https://gerrit.wikimedia.org/r/358963TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL
jmatazzoni added a comment.
In T164375#3344940, @Lydia_Pintscher wrote:
Ok let's go with "The page FOO was connected to the BAR item ITEMID. It contains data relevant to the topic." and link the whole thing to the Wikidata item.
In English, this formulation has the same problem. "It" here
Lydia_Pintscher added a comment.
Ok let's go with "The page FOO was connected to the BAR item ITEMID. It contains data relevant to the topic." and link the whole thing to the Wikidata item.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL
jmatazzoni added a comment.
The new text should be: "The page foo was connected to a bar item. It holds additional data about the topic."
In the second sentence, "it" would refer to the subject of the previous sentence, which is "the page." I don't think that's what you mean here. Also, I don't
Mattflaschen-WMF added a comment.
Or reverse it, and have the primary link go to Wikidata and a secondary link go to the local page. Nothing actually happened to the local page, so there's nothing to see there really.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL
