gerritbot added a comment.
Change 403192 abandoned by Lucas Werkmeister (WMDE):
Add lazy loading images and grid layout in rows to images
https://gerrit.wikimedia.org/r/403192TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 404402 merged by jenkins-bot:
[wikidata/query/gui@master] Add lazy loading and image rows
https://gerrit.wikimedia.org/r/404402TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 404402 had a related patch set uploaded (by StudentSydney; owner: StudentSydney):
[wikidata/query/gui@master] Add lazy loading and image rows
https://gerrit.wikimedia.org/r/404402TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 401897 abandoned by Jonas Kress (WMDE):
Add lazy loading of images in query results and display in rows
Reason:
https://gerrit.wikimedia.org/r/#/c/403192/
https://gerrit.wikimedia.org/r/401897TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 400407 abandoned by Jonas Kress (WMDE):
Implement infinite-scroll style lazy loading
Reason:
https://gerrit.wikimedia.org/r/#/c/403192/
https://gerrit.wikimedia.org/r/400407TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 402760 abandoned by Jonas Kress (WMDE):
Add lazy loading images and grid layout in rows to images
Reason:
Please work on:
https://gerrit.wikimedia.org/r/#/c/403192/
https://gerrit.wikimedia.org/r/402760TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 402626 abandoned by Jonas Kress (WMDE):
Add lazy image loading and display images in rows
Reason:
https://gerrit.wikimedia.org/r/#/c/403192/
https://gerrit.wikimedia.org/r/402626TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 399808 abandoned by Jonas Kress (WMDE):
Implement masonry and lazy loading on image results
Reason:
https://gerrit.wikimedia.org/r/#/c/403192/
https://gerrit.wikimedia.org/r/399808TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 403192 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: StudentSydney):
[wikidata/query/gui@master] Add lazy loading images and grid layout in rows to images
https://gerrit.wikimedia.org/r/403192TASK
gerritbot added a comment.
Change 402760 had a related patch set uploaded (by StudentSydney; owner: StudentSydney):
[wikidata/query/gui@master] Add lazy loading images and grid layout in rows to images
https://gerrit.wikimedia.org/r/402760TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 402626 had a related patch set uploaded (by StudentSydney; owner: StudentSydney):
[wikidata/query/gui@master] Add lazy image loading and display images in rows
https://gerrit.wikimedia.org/r/402626TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
gerritbot added a comment.
Change 401897 had a related patch set uploaded (by StudentSydney; owner: StudentSydney):
[wikidata/query/gui@master] Add lazy loading of images in query results and display in rows
https://gerrit.wikimedia.org/r/401897TASK
gerritbot added a comment.
Change 400407 had a related patch set uploaded (by StudentSydney; owner: StudentSydney):
[wikidata/query/gui@master] Implement infinite-scroll style lazy loading
https://gerrit.wikimedia.org/r/400407TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
StudentSydney added a comment.
I'm new at this so forgive me if I say anything dumb.
@Lucas_Werkmeister_WMDE made some good points. Are rows of uniform height acceptable, or is there some reason to use columns instead? Columns will always be awkwardly staggard at the bottom if the images above
gerritbot added a comment.
Change 399808 had a related patch set uploaded (by StudentSydney; owner: StudentSydney):
[wikidata/query/gui@master] Implement masonry and lazy loading on image results
https://gerrit.wikimedia.org/r/399808TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL
Jan_Dittrich added a comment.
We are currently working to capacity, so feedback will be brief, for now.
What about paging?: *1234 items found: 1 | 2 | 3 | … like google pages.
If I am not mistaken, the implementation at tumblr (only autoloading page that came to my mind) is that you scroll a bit
Lucas_Werkmeister_WMDE added a comment.
Yeah :)
One possibility to fix the “jumping around” issue would be to get the image sizes from the Commons API (action="">, prop=imageinfo, iiprop=size, titles=…) and to set fixed sizes on the tiles using that, before we start loading the images. However,
Jonas added a comment.
Now better?TASK DETAILhttps://phabricator.wikimedia.org/T166216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Lucas_Werkmeister_WMDE, Florian, rosalieper, PokestarFan, Aklapper, Jonas, TerraCodes, Lahi, Toppole69, JamieTubers,
Lucas_Werkmeister_WMDE added a comment.
The browser should only load images in the viewport.
When scrolling new images should be loaded.
for these two from me. Why should we wait to load the images (which will still take some time) until the user scrolls to them? That just means we’re making
19 matches
Mail list logo
