Charlie_WMDE added a comment.
Hey @Lydia_Pintscher,
I just realised that it's kinda strange that the Logo on the query page doesn't match the favicon icon.
F10430656: Screenshot_20171025_171602.png
I think it would be a good idea to have them be the same.
If the favicon was never intended to
gerritbot added a comment.
Change 377912 merged by jenkins-bot:
[wikidata/query/gui@master] Change favicon to "magnifying glass" image
https://gerrit.wikimedia.org/r/377912TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL
Charlie_WMDE added a comment.
In T168041#3625217, @Smalyshev wrote:
@Charlie_WMDE I've tried the ico file, it seems OK except for one issue which I'm not sure if it's ok or not: it has white (not transparent) background, which makes it look like white box, unlike wikidata icon. F9704937:
Smalyshev added a comment.
@Charlie_WMDE I've tried the ico file, it seems OK except for one issue which I'm not sure if it's ok or not: it has white (not transparent) background, which makes it look like white box, unlike wikidata icon. F9704937: screen.png Is it ok?TASK
Charlie_WMDE added a comment.
Hi @Smalyshev,
the file is a rectangle and has no margins. The whitespace you see is put there by Phabricator to make it look nicer I guess. If you take a look at the file on commons you can see it better.
220x200 is not the size for a favicon. Favicons vary in
Smalyshev added a comment.
Also, the PNG image seems to have pretty large margins, which makes the actual icon look very small.TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, Esc3300,
Smalyshev added a comment.
@Charlie_WMDE I don't think we can use SVG, due to limited support, and PNG is 220x200 - is that the size we should use for the icon? Typically icons are smaller...TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL
Charlie_WMDE added a comment.
Hey @Smalyshev the following file is the correct one:
F9531372: WD_Favicon_color_Query_black.png
https://commons.wikimedia.org/wiki/File:Wikidata_Query_Service_Favicon.svgTASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL
Smalyshev added a comment.
Looks like SVG support for icons is kinda spotty: https://en.wikipedia.org/wiki/Favicon#File_format_support
So PNG or ICO is probably the best option. @Charlie_WMDE could you point me to a final file that I should be using in the patch? Kinda confused among the
Charlie_WMDE added a comment.
In T168041#3615154, @Jonas wrote:
Sorry, but I would recommend the white version, because it is easier to see the difference than with black:
F9626135: image.png
Hey @Jonas that is not the favicon I suggested. It is harder to see because the Wikidata favicon isn't
Jan_Dittrich added a comment.
Slightly meta:
For making an informed decision suggest the following:
Test the icon on a black, 50% gray and white background (to cover common tab background colors).
Creating a mock tab can be helpful to see the icon in context.
Please take care that the version
Jonas added a comment.
Sorry, but I would recommend the white version, because it is easier to see the difference than with black:
F9626135: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc:
Charlie_WMDE added a comment.
F9554806: WD_Favicon_color_Query.svg
here's the svg in case that's neededTASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Charlie_WMDECc: gerritbot, Esc3300, PokestarFan,
Lydia_Pintscher added a comment.
Thanks a lot, Charlie! Let's go with the black one.TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, Esc3300, PokestarFan, Smalyshev,
Charlie_WMDE added a comment.
I suggest using the actual favicon in the background as mentioned in a previous comment to keep blurryness to a minimum.
I also think, that it's better visible in white in favicon size.
F9531506: WD_Favicon_color_Query_white_fav.png
F9531261:
Lydia_Pintscher added a comment.
When I look at the one that is in https://gerrit.wikimedia.org/r/377912 I see a horizontal white line at about 2/3 of the height. Besides that, go ahead.
@Charlie_WMDE can you get us a fixed version?TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL
Smalyshev added a comment.
@Lydia_Pintscher Can we use the icon from https://gerrit.wikimedia.org/r/377912 ?TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, Esc3300, PokestarFan,
gerritbot added a comment.
Change 377912 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/gui@master] Change favicon to "magnifying glass" image
https://gerrit.wikimedia.org/r/377912TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL
gerritbot added a comment.
Change 377665 merged by jenkins-bot:
[wikidata/query/gui@master] Change favicon to "magnifying glass" image
https://gerrit.wikimedia.org/r/377665TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL
gerritbot added a comment.
Change 377665 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/gui@master] Change favicon to "magnifying glass" image
https://gerrit.wikimedia.org/r/377665TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL
Esc3300 added a comment.
A month or two ago, the favicon for query.wikidata.org was set to the same as www.wikidata.org .. this made it highly confusing.
Please keep them different. The current color difference makes it easy to tell them apart.TASK
Lydia_Pintscher added a comment.
Alright. Both are fine from my side.TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Smalyshev, James_Budday, Jonas, Jan_Dittrich, Charlie_WMDE,
Jan_Dittrich added a comment.
@Lydia_Pintscher
it is "based on query (lines-horizontal) and visualization of results (bars-vertical)"TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc:
Lydia_Pintscher added a comment.
Either the one with the looking glass or the completely new one. What's the idea/meaning behind the completely new one?TASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Charlie_WMDE added a comment.
I like @Jan_Dittrich 's logo a lot since i feel like the query service deserves its own logo and that one makes a lot of sense and looks very nice.
If we do end up going with any of @James_Budday 's suggestions we should use the favicon logo in the background though
Smalyshev added a comment.
I like the magnifying glass one. Should be recognizable enough to word even when displayed in tiny size in the browser bar. F8788903: wikiquer2.pngTASK DETAILhttps://phabricator.wikimedia.org/T168041EMAIL
James_Budday added a comment.
This could be a pretty quick job if it hasn't been done already. My initial 2 ideas are the logo with a question mark or a magnifying glass. Here are 2 lazy, 10 second drafts. Would this be on the right track?
F8788903: wikiquer2.png
F8788902: wikiquer1.pngTASK
27 matches
Mail list logo
