hashar added a comment.
In logstash, the last trace matching idSerialization is 2017-07-20T16:56:19 and had:
/w/api.php?action="" InvalidArgumentException from line 39 of /srv/mediawiki/php-1.30.0-wmf.9/extensions/Wikidata/vendor/wikibase/data-model/src/Entity/ItemId.php: $idSerialization must
Lucas_Werkmeister_WMDE added a comment.
I don’t think anything has been backported for this issue, so I guess we’ll know for sure later today when the new build is deployed. (Where “we” is someone who has access to the logs, i. e. not me :) )TASK
Ladsgroup added a comment.
Is this resolved? It seems so.TASK DETAILhttps://phabricator.wikimedia.org/T170599EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, daniel, gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, TerraCodes, Jay8g,
gerritbot added a comment.
Change 365090 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix exception thrown from ConnectionCheckerHelper
https://gerrit.wikimedia.org/r/365090TASK DETAILhttps://phabricator.wikimedia.org/T170599EMAIL
Lucas_Werkmeister_WMDE added a comment.
Okay, the above change is a quick’n’dirty fix if you need it. Should apply cleanly on top of the currently deployed code.
I’ll create a separate task for the real solution.TASK DETAILhttps://phabricator.wikimedia.org/T170599EMAIL
gerritbot added a comment.
Change 365090 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix exception thrown from ConnectionCheckerHelper
https://gerrit.wikimedia.org/r/365090TASK
Lucas_Werkmeister_WMDE added a comment.
I notice two things:
ConnectionCheckerHelper::parseItemIdSnakValues processes values that can come from the constraint parameters, which are currently almost free-form text, so it definitely should catch parse exceptions. My bad – sorry.
In this stack
thcipriani added a comment.
Removed as train blocker, seems to have been happening pre 1.30.0-wmf.9, sorry for the noiseTASK DETAILhttps://phabricator.wikimedia.org/T170599EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thciprianiCc: Smalyshev,
