Lucas_Werkmeister_WMDE added a comment.
Wikibase part is merged as well, so we should be good to go. But unless someone thinks it’s serious enough for a backport, we’ll have to wait a bit for the next train (no train this and next week).TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL
Bawolff added a comment.
So core is fixed now, so we should be all clear to go ahead with the fix in wikidataTASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: gerritbot, Bawolff,
gerritbot added a comment.
Change 398821 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Escape autocomment message arguments
https://gerrit.wikimedia.org/r/398821TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL
gerritbot added a comment.
Change 398821 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Escape autocomment message arguments
https://gerrit.wikimedia.org/r/398821TASK
Bawolff added a comment.
Fix for gender at https://gerrit.wikimedia.org/r/398772TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: gerritbot, Bawolff, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86,
Bawolff added a comment.
I don’t think we can do that – {{GENDER}} needs the unescaped username. Otherwise we’ll address these users with the wrong gender. (I tried it out locally, {{GENDER:*asterisk|he|she|they}} produces “she” while {{GENDER:asterisk|he|she|they}} produces “they”.)
And weirdly
gerritbot added a comment.
Change 398081 abandoned by Lucas Werkmeister (WMDE):
Render autocomment parameters as plain text
Reason:
This was premature, see more discussion in the attached bug.
https://gerrit.wikimedia.org/r/398081TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL
Bawolff added a comment.
Hmm. Maybe thats a bug in GENDER: i would expect it to normalize titles.TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: gerritbot, Bawolff, Lucas_Werkmeister_WMDE,
Lucas_Werkmeister_WMDE added a comment.
Just use the wfEscapeWikitext() global function (Defined in includes/GlobalFunctions.php), that's the standard solution the rest of MediaWiki uses.
I don’t think we can do that – {{GENDER}} needs the unescaped username. Otherwise we’ll address these users
Lucas_Werkmeister_WMDE added a comment.
Alternative fix: wrap the user name in .
diff --git a/repo/i18n/en.json b/repo/i18n/en.json
index c93cfa413..cacb8b4fe 100644
--- a/repo/i18n/en.json
+++ b/repo/i18n/en.json
@@ -369,8 +369,8 @@
"wikibase-self-conflict-patched": "Your edit was patched into
Lucas_Werkmeister_WMDE added a comment.
Are there any other possible usernames that cause a bug like this? I could only find ;dl, definition list syntax (which is also only effective due to the {{GENDER}} template, and would otherwise have no special meaning in the middle of a line).
:, #, <, >,
Lucas_Werkmeister_WMDE added a comment.
But this suggests that moving the username out of the {{GENDER}} should be enough to fix the bug.
Well, it would fix the * bug. It won’t necessarily fix any other problems that may occur because we’re sending unescaped user names into a parsed message.
The
Lucas_Werkmeister_WMDE added a comment.
Hm, looks like that’s just standard behavior for any template (I tried it with foo{{identity|*bar}}, where Template:identity is just {{{1}}}). Odd, but not a bug.
But this suggests that moving the username out of the {{GENDER}} should be enough to fix the
Lucas_Werkmeister_WMDE added a comment.
Why is this even being parsed as a list, anyways? The plain text of the message is:
Restore revision 597045630 by [[Special:Contributions/*Youngjin|{{GENDER:*Youngjin|*Youngjin}}]]
There’s no * anywhere near the beginning of a line, and yet a list is
Lucas_Werkmeister_WMDE added a comment.
Hm, {{GENDER}} doesn’t seem to support usernames with asterisks anyways – if I’m not mistaken, they’re treated as “unknown gender”. (Unless that’s just a problem with my local test wiki.)TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL
Bawolff added a comment.
In T182800#3835104, @Lucas_Werkmeister_WMDE wrote:
Ah, but plaintext parameters are, like raw parameters, processed after the message is parsed, so {{PLURAL:$3|claim|claims}} no longer works :/
Oh, I didn't think about that. Just use a normal ->params() and wrap in
Lucas_Werkmeister_WMDE added a comment.
Hm, I’m not sure how to solve this. {{GENDER}} needs the unescaped username, but then how can we also include the username in the message without it being parsed? Do we need to pass the username into the message twice, once unescaped and once escaped?TASK
Lucas_Werkmeister_WMDE added a comment.
And the username is actually used inside a {{GENDER}} magic word for both messages where it appears, so I assume we simply can’t use plaintext…TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL
Lucas_Werkmeister_WMDE added a comment.
Ah, but plaintext parameters are, like raw parameters, processed after the message is parsed, so {{PLURAL:$3|claim|claims}} no longer works :/TASK DETAILhttps://phabricator.wikimedia.org/T182800EMAIL
gerritbot added a comment.
Change 398081 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Render autocomment parameters as plain text
https://gerrit.wikimedia.org/r/398081TASK
Bawolff added a comment.
In T182800#3834874, @Lucas_Werkmeister_WMDE wrote:
Possible fix:
diff --git a/lib/includes/Formatters/AutoCommentFormatter.php b/lib/includes/Formatters/AutoCommentFormatter.php
index 0c77d8762..b57ab5580 100644
--- a/lib/includes/Formatters/AutoCommentFormatter.php
+++
21 matches
Mail list logo
