Lucas_Werkmeister_WMDE added a comment.
This "?" would be a keyboard shortcut, not something I type in some box or so?
Yes, but by default the focus is inside the query editor. The ? becomes a keyboard shortcut when the query editor loses focus, e. g. by pressing Esc or by clicking somewhere.
Jan_Dittrich added a comment.
This "?" would be a keyboard shortcut, not something I type in some box or so?
@Lucas_Werkmeister_WMDE:
is already bound to toggle the “Help” menu, so that function needs a different key. h seems to be free :)
Which help menu? Query Service one or the browsers?TASK
gerritbot added a comment.
Change 401729 merged by jenkins-bot:
[wikidata/query/gui@master] Keyboard accessibility help dialog
https://gerrit.wikimedia.org/r/401729TASK DETAILhttps://phabricator.wikimedia.org/T183923EMAIL
eflyjason added a comment.
F12225770: Screen Shot 2018-01-03 at 9.43.47 PM.pngTASK DETAILhttps://phabricator.wikimedia.org/T183923EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, eflyjason, Jonas,
gerritbot added a comment.
Change 401729 had a related patch set uploaded (by Eflyjason; owner: Eflyjason):
[wikidata/query/gui@master] Keyboard accessibility help dialog
https://gerrit.wikimedia.org/r/401729TASK DETAILhttps://phabricator.wikimedia.org/T183923EMAIL
Lucas_Werkmeister_WMDE added a comment.
In T183923#3867473, @Aklapper wrote:
I fail to parse "Notice existing shortcut should get different key assigned." - care to elaborate? :)
? is already bound to toggle the “Help” menu, so that function needs a different key. h seems to be free :)TASK
Aklapper added a comment.
I fail to parse "Notice existing shortcut should get different key assigned." - care to elaborate? :)TASK DETAILhttps://phabricator.wikimedia.org/T183923EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Aklapper, eflyjason,
