gerritbot added a comment.
Change 406174 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Improve EntityContent::getTextForSummary()
https://gerrit.wikimedia.org/r/406174TASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL
gerritbot added a comment.
Change 406174 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Improve EntityContent::getTextForSummary()
https://gerrit.wikimedia.org/r/406174TASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL
Ladsgroup added a comment.
I love this bug, let me take a lookTASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lucas_Werkmeister_WMDE, Anomie, daniel, MisterSynergy, Izno,
Lucas_Werkmeister_WMDE added a comment.
The current default log message has three issues:
It only uses the description of the item, not the label (“content was: ""” happens when there was no description). We want either the label and the description, or just the label.
There are no language
Anomie added a comment.
Yes, CommentStore will be used for log comments too. There's probably not infrastructure in the LogPage or LogEntry classes to actually use it though, so you might have to add that.TASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL
daniel added a comment.
Side note: there is an idea to use the new CommentStore infrastructure for storing log comments, not just edit summaries. This would allow us to store the label in several languages inside the log comment, to provide localization even after the item itself has been deleted.
Yair_rand added a comment.
@Izno This is not the same as either of those, though it does deal with a related issue. The default contents of the log summary box can be changed by the deleting admin, and do not prevent hiding of information. Since there's no issue of the admin being unable to hide
Yair_rand added a comment.
@Sjoerddebruin The way that's handled for other types of pages is for the deleting admin to manually remove any problematic text from the deletion summary. Seems like that would work here as well.TASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL
Sjoerddebruin added a comment.
The label could contain information that is a violation of other policies on Wikidata, like privacy violation, harassment and stuff. But I agree that more information would be better.TASK DETAILhttps://phabricator.wikimedia.org/T184025EMAIL
