gerritbot added a comment.
Change 405904 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t load gadget when not in edit mode
https://gerrit.wikimedia.org/r/405904TASK DETAILhttps://phabricator.wikimedia.org/T184623EMAIL PREFERENCEShttps://phabricator.wikimedia.o
gerritbot added a comment.
Change 405904 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Don’t load gadget when not in edit mode
https://gerrit.wikimedia.org/r/405904TASK DETAILhttps://phabric
Lucas_Werkmeister_WMDE added a comment.
wbIsEditView still seems to be true on oldid pages if the ID is the current one. But apart from that, I think it makes sense to use wbIsEditView for this.TASK DETAILhttps://phabricator.wikimedia.org/T184623EMAIL PREFERENCEShttps://phabricator.wikimedia.org/se
thiemowmde added a comment.
I had a look, and yes, comparing wgRevisionId with wgCurRevisionId seems to be the way to go, along with checking if wgAction is "view".
There is also wbIsEditView (set by Wikibase) which is false on all diff and oldid pages, even if they show the current revision. Sure
Lucas_Werkmeister_WMDE added a comment.
and might even result in errors (I’m not sure if we correctly handle the case of $( statementId ) being an empty set if the statement doesn’t exist in the current version).
I tried it out briefly, and there didn’t seem to be any errors in the console. So I t
Lucas_Werkmeister_WMDE added a comment.
Do you have more information on this? At a glance, I only found wgRevisionId and wgCurRevisionId in mw.config which I could compare (and wgAction to check).TASK DETAILhttps://phabricator.wikimedia.org/T184623EMAIL PREFERENCEShttps://phabricator.wikimedia.org/
