[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 6)

2018-02-13 Thread gerritbot
gerritbot added a comment. Change 407657 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for FormatChecker https://gerrit.wikimedia.org/r/407657TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 6)

2018-02-13 Thread gerritbot
gerritbot added a comment. Change 407656 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for multilingual text to ViolationMessage https://gerrit.wikimedia.org/r/407656TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 3)

2018-02-08 Thread gerritbot
gerritbot added a comment. Change 408544 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Minor ViolationMessageRenderer improvements https://gerrit.wikimedia.org/r/408544TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 3)

2018-02-08 Thread gerritbot
gerritbot added a comment. Change 407710 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for language to ViolationMessage https://gerrit.wikimedia.org/r/407710TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 3)

2018-02-08 Thread gerritbot
gerritbot added a comment. Change 407709 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for constraint scope lists to ViolationMessage https://gerrit.wikimedia.org/r/407709TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-07 Thread gerritbot
gerritbot added a comment. Change 407707 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Inject Config into ViolationMessageRenderer https://gerrit.wikimedia.org/r/407707TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-07 Thread gerritbot
gerritbot added a comment. Change 407708 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for constraint scopes to ViolationMessage https://gerrit.wikimedia.org/r/407708TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-06 Thread gerritbot
gerritbot added a comment. Change 408544 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Minor ViolationMessageRenderer improvements https://gerrit.wikimedia.org/r/408544TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-06 Thread gerritbot
gerritbot added a comment. Change 407655 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Simplify ViolationMessageRenderer::renderArgument https://gerrit.wikimedia.org/r/407655TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-06 Thread gerritbot
gerritbot added a comment. Change 407654 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Make ViolationMessageRenderer::renderArgument return params https://gerrit.wikimedia.org/r/407654TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-06 Thread gerritbot
gerritbot added a comment. Change 407653 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for inline code to ViolationMessage https://gerrit.wikimedia.org/r/407653TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot
gerritbot added a comment. Change 407709 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for constraint scope lists to ViolationMessage https://gerrit.wikimedia.org/r/407709TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot
gerritbot added a comment. Change 407710 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for language to ViolationMessage https://gerrit.wikimedia.org/r/407710TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot
gerritbot added a comment. Change 407708 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for constraint scopes to ViolationMessage https://gerrit.wikimedia.org/r/407708TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot
gerritbot added a comment. Change 407707 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Inject Config into ViolationMessageRenderer https://gerrit.wikimedia.org/r/407707TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot
gerritbot added a comment. Change 407657 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for FormatChecker https://gerrit.wikimedia.org/r/407657TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot
gerritbot added a comment. Change 407655 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Simplify ViolationMessageRenderer::renderArgument https://gerrit.wikimedia.org/r/407655TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot
gerritbot added a comment. Change 407656 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for multilingual text to ViolationMessage https://gerrit.wikimedia.org/r/407656TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot
gerritbot added a comment. Change 407654 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Make ViolationMessageRenderer::renderArgument return params https://gerrit.wikimedia.org/r/407654TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot
gerritbot added a comment. Change 407653 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for inline code to ViolationMessage https://gerrit.wikimedia.org/r/407653TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407044 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add test for ViolationMessage arguments with unknown type https://gerrit.wikimedia.org/r/407044TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407037 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add missing test for ViolationMessageRenderer https://gerrit.wikimedia.org/r/407037TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407036 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for range checkers https://gerrit.wikimedia.org/r/407036TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407035 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for data values to ViolationMessage https://gerrit.wikimedia.org/r/407035TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407033 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Remove argument to ViolationMessageRenderer::render() https://gerrit.wikimedia.org/r/407033TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407013 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for even more checkers https://gerrit.wikimedia.org/r/407013TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 2)

2018-02-01 Thread gerritbot
gerritbot added a comment. Change 407012 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for data value types to ViolationMessage https://gerrit.wikimedia.org/r/407012TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407044 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add test for ViolationMessage arguments with unknown type https://gerrit.wikimedia.org/r/407044TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407033 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Remove argument to ViolationMessageRenderer::render() https://gerrit.wikimedia.org/r/407033TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407037 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add missing test for ViolationMessageRenderer https://gerrit.wikimedia.org/r/407037TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407036 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for range checkers https://gerrit.wikimedia.org/r/407036TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407035 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for data values to ViolationMessage https://gerrit.wikimedia.org/r/407035TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407008 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for ItemIdSnakValue lists to ViolationMessage https://gerrit.wikimedia.org/r/407008TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407009 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for more checkers https://gerrit.wikimedia.org/r/407009TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407007 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Refactor ViolationMessageRenderer https://gerrit.wikimedia.org/r/407007TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407001 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Remove ViolationMessageRenderer::render parameters https://gerrit.wikimedia.org/r/407001TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407012 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for data value types to ViolationMessage https://gerrit.wikimedia.org/r/407012TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407013 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for even more checkers https://gerrit.wikimedia.org/r/407013TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407000 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for messages with ItemIdSnakValues https://gerrit.wikimedia.org/r/407000TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406994 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for ItemIdSnakValues to ViolationMessage https://gerrit.wikimedia.org/r/406994TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407008 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for ItemIdSnakValue lists to ViolationMessage https://gerrit.wikimedia.org/r/407008TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407009 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for more checkers https://gerrit.wikimedia.org/r/407009TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407007 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Refactor ViolationMessageRenderer https://gerrit.wikimedia.org/r/407007TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406993 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Split up @covers of ViolationMessageRendererTest https://gerrit.wikimedia.org/r/406993TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406991 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add test for (not) rendering a pre-rendered message https://gerrit.wikimedia.org/r/406991TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406992 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Simplify some ViolationMessageRenderer tests https://gerrit.wikimedia.org/r/406992TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407001 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Remove ViolationMessageRenderer::render parameters https://gerrit.wikimedia.org/r/407001TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 407000 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for messages with ItemIdSnakValues https://gerrit.wikimedia.org/r/407000TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406991 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add test for (not) rendering a pre-rendered message https://gerrit.wikimedia.org/r/406991TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406994 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for ItemIdSnakValues to ViolationMessage https://gerrit.wikimedia.org/r/406994TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406993 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Split up @covers of ViolationMessageRendererTest https://gerrit.wikimedia.org/r/406993TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406992 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Simplify some ViolationMessageRenderer tests https://gerrit.wikimedia.org/r/406992TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406835 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for messages with entity ID lists https://gerrit.wikimedia.org/r/406835TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406834 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for entity ID lists to ViolationMessage https://gerrit.wikimedia.org/r/406834TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406569 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for messages with entity IDs https://gerrit.wikimedia.org/r/406569TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-31 Thread gerritbot
gerritbot added a comment. Change 406568 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for entity ID arguments to ViolationMessage https://gerrit.wikimedia.org/r/406568TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-30 Thread gerritbot
gerritbot added a comment. Change 406834 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for entity ID lists to ViolationMessage https://gerrit.wikimedia.org/r/406834TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-01-30 Thread gerritbot
gerritbot added a comment. Change 406835 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for messages with entity ID lists https://gerrit.wikimedia.org/r/406835TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-30 Thread gerritbot
gerritbot added a comment. Change 406298 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for messages with no arguments https://gerrit.wikimedia.org/r/406298TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-30 Thread gerritbot
gerritbot added a comment. Change 406297 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Use null instead of '' as message for compliance https://gerrit.wikimedia.org/r/406297TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-30 Thread gerritbot
gerritbot added a comment. Change 406295 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add ViolationMessageRenderer https://gerrit.wikimedia.org/r/406295TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-30 Thread gerritbot
gerritbot added a comment. Change 406296 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Accept ViolationMessage in CheckResult https://gerrit.wikimedia.org/r/406296TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-30 Thread gerritbot
gerritbot added a comment. Change 406294 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add ViolationMessage class https://gerrit.wikimedia.org/r/406294TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-29 Thread gerritbot
gerritbot added a comment. Change 406568 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add support for property ID arguments to ViolationMessage https://gerrit.wikimedia.org/r/406568TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-29 Thread gerritbot
gerritbot added a comment. Change 406569 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for messages with property IDs https://gerrit.wikimedia.org/r/406569TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-26 Thread gerritbot
gerritbot added a comment. Change 406298 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for messages with no arguments https://gerrit.wikimedia.org/r/406298TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-26 Thread gerritbot
gerritbot added a comment. Change 406295 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add ViolationMessageRenderer https://gerrit.wikimedia.org/r/406295TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-26 Thread gerritbot
gerritbot added a comment. Change 406296 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Accept ViolationMessage in CheckResult https://gerrit.wikimedia.org/r/406296TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-26 Thread gerritbot
gerritbot added a comment. Change 406297 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use null instead of '' as message for compliance https://gerrit.wikimedia.org/r/406297TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-26 Thread gerritbot
gerritbot added a comment. Change 406294 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add ViolationMessage class https://gerrit.wikimedia.org/r/406294TASK

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages

2018-01-25 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Suggested names: ViolationMessage and ViolationMessageRenderer. (Non-violations simply have a null message – we currently use '' for those, anyways.) But that’s slightly inaccurate because bad-parameters results aren’t strictly speaking violations… any