gerritbot added a comment.
Change 416668 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Make ContextCursor serializable
https://gerrit.wikimedia.org/r/416668TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 416667 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add more getters to ContextCursor
https://gerrit.wikimedia.org/r/416667TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 416668 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Make ContextCursor serializable
https://gerrit.wikimedia.org/r/416668TASK
gerritbot added a comment.
Change 416667 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add more getters to ContextCursor
https://gerrit.wikimedia.org/r/416667TASK
gerritbot added a comment.
Change 416425 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove Context::storeCheckResultInArray and ApiV2Context
https://gerrit.wikimedia.org/r/416425TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 416425 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove Context::storeCheckResultInArray and ApiV2Context
https://gerrit.wikimedia.org/r/416425TASK
gerritbot added a comment.
Change 415550 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace CheckResult’s Context with ContextCursor
https://gerrit.wikimedia.org/r/415550TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 415549 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add snaks to test context mocks
https://gerrit.wikimedia.org/r/415549TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 415548 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add item IDs to test items
https://gerrit.wikimedia.org/r/415548TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 415547 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add and use CheckResult::getContextCursor()
https://gerrit.wikimedia.org/r/415547TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 415546 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add some getters to ContextCursor
https://gerrit.wikimedia.org/r/415546TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 413775 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove CheckResult::getEntityId()
https://gerrit.wikimedia.org/r/413775TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 413774 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add Context::getCursor getter
https://gerrit.wikimedia.org/r/413774TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 413773 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ContextCursor interface and implementations
https://gerrit.wikimedia.org/r/413773TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
gerritbot added a comment.
Change 415549 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add snaks to test context mocks
https://gerrit.wikimedia.org/r/415549TASK
gerritbot added a comment.
Change 415548 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add item IDs to test items
https://gerrit.wikimedia.org/r/415548TASK
gerritbot added a comment.
Change 415550 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Replace CheckResult’s Context with ContextCursor
https://gerrit.wikimedia.org/r/415550TASK
gerritbot added a comment.
Change 415546 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add some getters to ContextCursor
https://gerrit.wikimedia.org/r/415546TASK
gerritbot added a comment.
Change 415547 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add and use CheckResult::getContextCursor()
https://gerrit.wikimedia.org/r/415547TASK
Lucas_Werkmeister_WMDE added a comment.
In T185712#3997210, @Lucas_Werkmeister_WMDE wrote:
I forgot one thing… CheckResult also has getters for the snak type and data value, which are used in the special page. We definitely don’t want to add the data value to the cache, but I’m not sure how we
gerritbot added a comment.
Change 413774 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add Context::getCursor getter
https://gerrit.wikimedia.org/r/413774TASK
gerritbot added a comment.
Change 413775 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove CheckResult::getEntityId()
https://gerrit.wikimedia.org/r/413775TASK
gerritbot added a comment.
Change 413773 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ContextCursor interface and implementations
https://gerrit.wikimedia.org/r/413773TASK
Lucas_Werkmeister_WMDE added a comment.
I forgot one thing… CheckResult also has getters for the snak type and data value, which are used in the special page. We definitely don’t want to add the data value to the cache, but I’m not sure how we can keep the special page functionality in that
Ladsgroup added a comment.
:(((TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer,
Lucas_Werkmeister_WMDE added a comment.
To build a cursor, you need the statement GUID, which StatementContext currently doesn’t expose. So the alternative would be another method, getSurroundingStatement or something like that, as far as I can see :/TASK
Ladsgroup added a comment.
In T185712#3996246, @Lucas_Werkmeister_WMDE wrote:
Okay, so how about this:
Add Context::getCursor(), to return the associated ContextCursor.
I really like to avoid more public methods in Context, my recommendation is to have a public static function named
Lucas_Werkmeister_WMDE added a comment.
Okay, so how about this:
Extract Context::storeCheckResultInArray into a separate interface. (I’ll go with ContextCursor for now – I don’t think CompactContext or something like that really fits, because this isn’t just a different representation of a
Lucas_Werkmeister_WMDE added a comment.
I don’t fully understand your proposal yet… what would be the use of newFromContext? Would you store the resulting Context object directly in the cache, instead of serializing it into some array form?TASK DETAILhttps://phabricator.wikimedia.org/T185712EMAIL
Ladsgroup added a comment.
I would suggest going with another class named "CompactContext" or "SerializerableContext" which has two (more) public functions. "newFromContext" which tuns the context to smallest size possible and returns a new self and other method that turns the compact version into
Lucas_Werkmeister_WMDE added a comment.
I admit I’m tempted to go with the much simpler … fake EntityDocument …
Hm, though if we do go with a temporary solution, an alternative approach would be a new Context implementation, which only supports storeCheckResultInArray (because that’s all we need
Lucas_Werkmeister_WMDE added a comment.
I’m not sure how this would look – non-static serialize and static deserialize methods on Context and its subclasses? Or should it be a separate kind of ContextSerialization service? I think my colleagues know more about this than me, there’s a lot of
32 matches
Mail list logo
