[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-20 Thread gerritbot
gerritbot added a comment. Change 425851 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Add browser tests for undoing change that added grammatical feature https://gerrit.wikimedia.org/r/425851TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-17 Thread gerritbot
gerritbot added a comment. Change 424364 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] FormPatcher: test removing grammatical features https://gerrit.wikimedia.org/r/424364TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-12 Thread gerritbot
gerritbot added a comment. Change 425851 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/WikibaseLexeme@master] Add browser tests for undoing change that added grammatical feature https://gerrit.wikimedia.org/r/425851TASK

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-12 Thread gerritbot
gerritbot added a comment. Change 424364 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/WikibaseLexeme@master] FormPatcher: test removing grammatical features https://gerrit.wikimedia.org/r/424364TASK

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-12 Thread WMDE-leszek
WMDE-leszek added a comment. Related PRs (arguably not blockers for this task): https://github.com/wmde/WikibaseDataModelServices/pull/194 and https://gerrit.wikimedia.org/r/#/c/425770/TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-11 Thread WMDE-leszek
WMDE-leszek added a comment. Related PR into Diff library: https://github.com/wmde/Diff/pull/94.TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Pablo-WMDE, gerritbot, Addshore,

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-06 Thread WMDE-leszek
WMDE-leszek added a comment. The failure has been tracked down to issue with patching removing a grammatical feature. It is shown off e.g. by https://gerrit.wikimedia.org/r/#/c/424364/. The possible way of fixing was suggested as: https://github.com/wmde/Diff/pull/92. Alternatively, I am going to

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-05 Thread gerritbot
gerritbot added a comment. Change 423872 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Also check forms diff in LexemeDiff::isEmpty https://gerrit.wikimedia.org/r/423872TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 423867 abandoned by Addshore: WIP SCRATCH: Investigate grammatical feature undo failings https://gerrit.wikimedia.org/r/423867TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 423915 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] Add test for LexemeContent::getPatchedCopy https://gerrit.wikimedia.org/r/423915TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 423872 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] Also check forms diff in LexemeDiff::isEmpty https://gerrit.wikimedia.org/r/423872TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread Addshore
Addshore added a comment. It looks like this is specifically to do with undoing of an edit that adds a grammatical feature.TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Pablo-WMDE, gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 423867 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] WIP SCRATCH: Investigate grammatical feature undo failings https://gerrit.wikimedia.org/r/423867TASK

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread Addshore
Addshore added a comment. In T187215#4100512, @Lydia_Pintscher wrote: Sorry here is the diff: https://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L230=29727=29726 So it looks like there is still some issue with grammatical features, I'll investigate..TASK

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-03 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Sorry here is the diff: https://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L230=29727=29726TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore,

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-03 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. I tried to undo this edit: https://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L230=29727 Not working for me still.TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-03 Thread Addshore
Addshore added a comment. It looks like it is working for me https://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L571=29731=29730TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Pablo-WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-03 Thread Addshore
Addshore added a comment. In T187215#4100092, @Lydia_Pintscher wrote: I just tested it and it does not work. Please have another look. Thanks! Hmm, where did you test it? Has this been pulled onto the test system (*hasn't seen any docs on how to do that so hasn't done it*)TASK

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-03-27 Thread Pablo-WMDE
Pablo-WMDE added a comment. Also https://gerrit.wikimedia.org/r/#/c/421508/TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Pablo-WMDECc: Pablo-WMDE, gerritbot, Addshore, Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-03-26 Thread gerritbot
gerritbot added a comment. Change 421514 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] FormSetTest: CS https://gerrit.wikimedia.org/r/421514TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-03-23 Thread gerritbot
gerritbot added a comment. Change 421514 had a related patch set (by Pablo Grass (WMDE)) published: [mediawiki/extensions/WikibaseLexeme@master] FormSetTest: CS https://gerrit.wikimedia.org/r/421514TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-03-23 Thread gerritbot
gerritbot added a comment. Change 419450 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Add __clone and copy to FormSet https://gerrit.wikimedia.org/r/419450TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-03-14 Thread gerritbot
gerritbot added a comment. Change 419450 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] WIP DNM Add __clone and copy to FormSet https://gerrit.wikimedia.org/r/419450TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-03-12 Thread Addshore
Addshore added a comment. It looks like "Restore" also doesn't work!TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique,