[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-03-05T20:02:00Z] Synchronized php-1.31.0-wmf.23/extensions/Wikibase: Fix empty condition list in metadata lookup - T188313 (duration: 01m 58s)TASK DETAILhttps://phabricator.wikimedia.org/T188313EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

gerritbot added a comment. Change 415319 merged by Hashar: [mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.23] Fix empty condition list in metadata lookup https://gerrit.wikimedia.org/r/415319TASK DETAILhttps://phabricator.wikimedia.org/T188313EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

gerritbot added a comment. Change 415319 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.23] Fix empty condition list in metadata lookup https://gerrit.wikimedia.org/r/415319TASK

[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

gerritbot added a comment. Change 415071 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix empty condition list in metadata lookup https://gerrit.wikimedia.org/r/415071TASK DETAILhttps://phabricator.wikimedia.org/T188313EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

gerritbot added a comment. Change 415071 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Fix empty condition list in metadata lookup https://gerrit.wikimedia.org/r/415071TASK

[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

gerritbot added a comment. Change 415064 abandoned by Lucas Werkmeister (WMDE): DNM: add test without fixing bug Reason: Nevermind, I got a working setup now. And it’ll look better on the task if I abandon this change and upload a new one instead of updating this one… I didn’t think this through

[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

gerritbot added a comment. Change 415064 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] DNM: add test without fixing bug https://gerrit.wikimedia.org/r/415064TASK

[Wikidata-bugs] [Maniphest] [Commented On] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

daniel added a comment. I think [ false ] would result in WHERE (), which is a syntax error. I'd probably go for '1=2'.TASK DETAILhttps://phabricator.wikimedia.org/T188313EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel,