gerritbot added a comment.
Change 422426 abandoned by Jakob:
Disallow Lexemes having no lemmas
Reason:
Alternative solution as discussed in https://phabricator.wikimedia.org/T189185
https://gerrit.wikimedia.org/r/422426TASK DETAILhttps://phabricator.wikimedia.org/T189185EMAIL PREFERENCEShttps://p
WMDE-leszek added a comment.
@Lydia_Pintscher: this is ready to be tested at https://wikidata-lexeme.wmflabs.orgTASK DETAILhttps://phabricator.wikimedia.org/T189185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, WMDE-leszek, Pablo-WMD
gerritbot added a comment.
Change 423932 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Do not allow saving lexemes without a lemma
https://gerrit.wikimedia.org/r/423932TASK DETAILhttps://phabricator.wikimedia.org/T189185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setti
gerritbot added a comment.
Change 423932 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Do not allow saving lexemes without a lemma
https://gerrit.wikimedia.org/r/423932TASK DETAILhttps://phabricator.wikimedia.org/T189185EMAIL PR
WMDE-leszek added a comment.
I've had a stab at making constructor parameters related to required properties of Lexeme non-nullable and it seems to break several places where there are explicit new Lexeme() calls.
It seems there are several situations the "empty" lexeme has been created, as discus
Pablo-WMDE added a comment.
Discussion had:
create spike:
remove nullable for (per data model) required properties of Lexeme
create LemmaList extension of TermList
enforce prevention of empty LemmaList inside LemmaList
TASK DETAILhttps://phabricator.wikimedia.org/T189185EMAIL PREFERENCEShttps://
Addshore added a comment.
As a follow up to this, or added to this tase we should check all other APIs that allow editing / removing of lemmas to ensure this can't happen anywhere else.TASK DETAILhttps://phabricator.wikimedia.org/T189185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pa
