Krinkle added a comment.
In T189329#4074806, @Huji wrote:
I assume the failed test on PS1 of https://gerrit.wikimedia.org/r/#/c/421468/ is the same issue, right?
No, this task is about a flaky QUnit _javascript_ Test from Wikibase’s editor.
The failure on your Gerrit change is from HHVM
Huji added a comment.
I assume the failed test on PS1 of https://gerrit.wikimedia.org/r/#/c/421468/ is the same issue, right?TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: Tgr, hashar, gerritbot,
gerritbot added a comment.
Change 419963 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Skip flaky Wikibase tests
https://gerrit.wikimedia.org/r/419963TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL
hoo added a comment.
In T189329#4055461, @Krinkle wrote:
It's been a week. I think it's fair to expect the following at this point: Wikibase has 24 hours to either fix or disable the offending QUnit test(s). Alternatively, Wikibase will be removed from the shared extension gate sometime tomorrow.
gerritbot added a comment.
Change 419963 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Skip flaky Wikibase tests
https://gerrit.wikimedia.org/r/419963TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL
Krinkle added a comment.
It's been a week. I think it's fair to expect the following at this point: Wikibase has 24 hours to either fix or disable the offending QUnit test(s). Alternatively, Wikibase will be removed from the extension gate sometime tomorrow.
The small amount of code coverage loss
Smalyshev added a comment.
From today: https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/56819/console
Doesn't seem to be fixed.TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Daimona added a comment.
I'd say not fixed: https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/56813/console just now.TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: hoo,
hoo added a comment.
I also can't reproduce these failures locally in any of my browsers (although I didn't try to hard and I have other local failures I need to filter out) :/TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL
Lucas_Werkmeister_WMDE added a comment.
Ie1280e50bf still had a lot of failures earlier this morning, do you think it’s been fixed since then?TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Jonas added a comment.
So, it seems to be fixed.
I also had trouble reproducing it locally.
Any more gerrit patches that fail?TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Mbch331, Jonas,
Mbch331 added a comment.
https://gerrit.wikimedia.org/r/#/c/406399/ fails on this as wellTASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mbch331Cc: Mbch331, Jonas, TerraCodes, Liuxinyu970226, Niharika,
Niharika added a comment.
Also seen on https://gerrit.wikimedia.org/r/#/c/419101/TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NiharikaCc: Niharika, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF,
13 matches
Mail list logo
