gerritbot added a comment.
Change 423867 abandoned by Addshore:
WIP SCRATCH: Investigate grammatical feature undo failings
https://gerrit.wikimedia.org/r/423867TASK DETAILhttps://phabricator.wikimedia.org/T189580EMAIL
gerritbot added a comment.
Change 423867 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] WIP SCRATCH: Investigate grammatical feature undo failings
https://gerrit.wikimedia.org/r/423867TASK
gerritbot added a comment.
Change 419450 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add __clone and copy to FormSet
https://gerrit.wikimedia.org/r/419450TASK DETAILhttps://phabricator.wikimedia.org/T189580EMAIL
Addshore added a comment.
In T189580#4050690, @WMDE-leszek wrote:
Do you want to add a test "showcasing" the bug @Addshore, so we could have it fixed (with the patch you provided I assume), and shall we call the investigation done then, or do we call it done now?
I think we can leave the
WMDE-leszek added a comment.
I can confirm that using the patch linked above, it seems that having cloning of FormSet added, undoing and restoring works fine.
The explanation provided above also seems legit to me.
Do you want to add a test "showcasing" the bug @Addshore, so we could have it fixed
Addshore added a comment.
It may also be worth doing a general audit of all other Lexeme DM objects to make sure no other clones that are needed are missing so we don't run into the same issue in other places / with other types of edit.TASK DETAILhttps://phabricator.wikimedia.org/T189580EMAIL
gerritbot added a comment.
Change 419450 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] WIP DNM Add __clone and copy to FormSet
https://gerrit.wikimedia.org/r/419450TASK DETAILhttps://phabricator.wikimedia.org/T189580EMAIL
Addshore added a comment.
So debugging has lead me to SubmitEntityAction::undo in wikibase, and the following code snippet.
if ( $patchedContent->equals( $latestContent ) ) {
$status = Status::newGood();
$status->warning( 'wikibase-empty-undo' );
} else {
/// ...
}
