gerritbot added a comment.
Change 420708 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CheckResultsRenderer
https://gerrit.wikimedia.org/r/420708TASK DETAILhttps://phabricator.wikimedia.
gerritbot added a comment.
Change 420707 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ResultsSource and CheckingResultsSource
https://gerrit.wikimedia.org/r/420707TASK DETAILhttps://pha
gerritbot added a comment.
Change 420706 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add CachedCheckResults
https://gerrit.wikimedia.org/r/420706TASK DETAILhttps://phabricator.wikimedia.or
Lucas_Werkmeister_WMDE added a comment.
Oh, and we need a place where we actually do the conversion of CheckResults to arrays and store them all in the giant result structure, since ResultsSource doesn’t do that anymore. (This is also the step where ViolationMessages are rendered.) Is that a CheckR
Lucas_Werkmeister_WMDE added a comment.
I suppose it could be just a ResultsSource. Very generic, but matches ResultsBuilder. CheckingResultsSource and CachingResultsSource don’t sound too bad to me.TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.o
Lucas_Werkmeister_WMDE added a comment.
Perhaps a CheckResultsSource? But that doesn’t really yield any good names for the implementation (a CheckingCheckResultsSource?).TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefer
Lucas_Werkmeister_WMDE added a comment.
So what do we have instead?
CachedCheckResults: wrapper around CheckResult[] + Metadata. (Note: since the results may be filtered, the overall metadata may be more than the merge of the individual CheckResult metadatas!)
something which takes the same param
Lucas_Werkmeister_WMDE added a comment.
Hm, we don’t need a hybrid phase, but this is still a big change – and it pretty much invalidates the current interface of CachedCheckConstraintsResponse and ResultsBuilder, so perhaps it would be better to build up a new interface with new implementations in
