Marostegui added a comment.
In T190153#4064867, @jcrespo wrote:
"too soon" in that the structure was not stable, even if it was merged.
Ah right :-)TASK DETAILhttps://phabricator.wikimedia.org/T190153EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
jcrespo added a comment.
"too soon" in that the structure was not stable, even if it was merged.TASK DETAILhttps://phabricator.wikimedia.org/T190153EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: jcrespo, Marostegui, aude, Addshore, Aklapper,
jcrespo added a comment.
+1 in case there are more changesTASK DETAILhttps://phabricator.wikimedia.org/T190153EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: jcrespo, Marostegui, aude, Addshore, Aklapper, Anomie, Tgr, daniel, Lahi, PDrouin-WMF,
Marostegui added a comment.
In T190153#4064836, @jcrespo wrote:
Ok, Manuel haven't communicated to me and I wasn't on that ticket. Apparently the tables were created too soon.
As far as I remember the tables were created once the patch was merged.TASK
daniel added a comment.
@amonie, @aude: let's wait with re-creating the table until we need it, before running the populating script in phase I.TASK DETAILhttps://phabricator.wikimedia.org/T190153EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc:
daniel added a comment.
@Marostegui wrote:
Sure, I can drop the table in core (I will check to make sure it has no data) and you can take care of creating it again with the correct schema?
Sounds good, thank you!TASK DETAILhttps://phabricator.wikimedia.org/T190153EMAIL
jcrespo added a comment.
Ok, Manuel haven't communicated to me and I wasn't on that ticket. Apparently the tables were created too soon.TASK DETAILhttps://phabricator.wikimedia.org/T190153EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: jcrespo,
daniel added a comment.
@jcrespo I had actually forgotten that we had already created these tables. But apparently you approved it: T183486#3883181TASK DETAILhttps://phabricator.wikimedia.org/T190153EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc:
jcrespo added a comment.
Whoever deployed the table, violated the advice when creating new tables: "However, due to labs filtering limitation (hopefully, to be solved soon) you still should block on a DBA to review the table creation to check data leak is not possible."
Marostegui added a comment.
In T190153#4064762, @daniel wrote:
@Marostegui If that's fine with you, that's fine with me.
Sure, I can drop the table in core (I will check to make sure it has no data) and you can take care of creating it again with the correct schema?TASK
daniel added a comment.
If that's fine with you, that's fine with me.TASK DETAILhttps://phabricator.wikimedia.org/T190153EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Marostegui, aude, Addshore, Aklapper, Anomie, Tgr, daniel, Lahi, PDrouin-WMF,
Marostegui added a comment.
If we are sure it is completely empty, it might be easier and faster to drop it (if exists) and then recreate it, so you guys aren't blocked in the DBAs (as the create table can be done during a deployment by devs)TASK
12 matches
Mail list logo
