Lucas_Werkmeister_WMDE added a comment.
Okay, the Python rewrite is done, no more shell script :)
@Lea_Lacroix_WMDE can you take a look at the new UI? If you’re okay with it (and after we’ve added the short introduction text), I think we could close this task, and do any further improvements in
Lucas_Werkmeister_WMDE added a comment.
Great, thanks! We can probably get rid of most of runScript() once the port to Python is done (I’ll continue working on this today).TASK DETAILhttps://phabricator.wikimedia.org/T190812EMAIL
Ladsgroup added a comment.
I also reviewed the code and it looks pretty nice except the runScript() function that would be great if you can split it into smaller functions.TASK DETAILhttps://phabricator.wikimedia.org/T190812EMAIL
Ladsgroup added a comment.
I did flake8 fixes in https://phabricator.wikimedia.org/R2307:91f39748c3dcfbc97b06a13f10f75df5c31d47cfTASK DETAILhttps://phabricator.wikimedia.org/T190812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE,
Lucas_Werkmeister_WMDE added a comment.
Great, thanks! That should make the tool much easier to understand :)
I’ve pushed some work in progress to the repository, but not deployed it to Toolforge yet. I’ll probably continue working on this after the long weekend.TASK
Lea_Lacroix_WMDE added a comment.
Looks very good, thanks!
I'll prepare a short introduction text to add under the title of the tool.TASK DETAILhttps://phabricator.wikimedia.org/T190812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE,
Lucas_Werkmeister_WMDE added a comment.
And I'm afraid that the "use talk page" checkbox is needed for each field. For example if I write to Project:Lua pages with fallback Village pumps, for the first I need to write on the talk page, for the second it's the main page ^^"
Yeah, I realized the
Lea_Lacroix_WMDE added a comment.
Thanks for the select multiple! Looks good to me.
Let's try with 3 possible combinations, each having 2 possible fallbacks. I think that covers most of our usecases.
And I'm afraid that the "use talk page" checkbox is needed for each field. For example if I
Lucas_Werkmeister_WMDE added a comment.
About the “use talk page” checkbox – if we support combinations of target pages, how many times does that checkbox need to be there? Do we need one checkbox per “write to…” row, applying to all the fallbacks as well? Or does this need to be configurable per
Lucas_Werkmeister_WMDE added a comment.
Support for more than one wikigroup now available. I went for a after all, since I couldn’t figure out a good way to style a long list of checkboxes… is that okay?TASK DETAILhttps://phabricator.wikimedia.org/T190812EMAIL
Lucas_Werkmeister_WMDE added a comment.
By the way, we now have a proper Diffusion repository for this tool: https://phabricator.wikimedia.org/source/tool-wdmm/TASK DETAILhttps://phabricator.wikimedia.org/T190812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Lucas_Werkmeister_WMDE added a comment.
Hm, for the combinations I could think of something textual like Q123+(Q456,Q789) but I guess that’s not very usable :)
If we limit it to a fixed number of fields, I guess it should still be possible, with something like:
Write to: [item ID 1] falling
Lea_Lacroix_WMDE added a comment.
Thanks @Lucas_Werkmeister_WMDE for this first prototype! Two things I'd like your opinion on:
I think there are two different stories about selecting items.
the "fallback" case: I want the technical village pumps OR, if it doesn't exist on the wiki, the regular
Lucas_Werkmeister_WMDE added a comment.
Okay, the tool has a proper index page now, plus loads more features. Please take a look at https://tools.wmflabs.org/wdmm/! (pinging @Lea_Lacroix_WMDE)
Still no Diffusion or GitHub repository, but I symlinked the source code into tools-static as a
Lucas_Werkmeister_WMDE added a comment.
For this first version I would suggest two paths:
index.html, a simple static website with a form. (Technically, probably a Jinja2 template served by Flask, but I’m not sure if we’ll use any templating features.) The form POSTs to massmessage.
massmessage,
15 matches
Mail list logo
