gerritbot added a comment.
Change 445221 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445221TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445228 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445228TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445226 merged by jenkins-bot:
[mediawiki/extensions/SpamBlacklist@master] Replace deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445226TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445227 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Replace deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445227TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445224 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Replace deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445224TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445223 merged by jenkins-bot:
[mediawiki/extensions/ParsoidBatchAPI@master] Avoid deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445223TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445220 merged by jenkins-bot:
[mediawiki/core@master] Deprecate ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445220TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
Anomie added a comment.
In T194263#4420512, @daniel wrote:
The longer I think about this, the more I want ParserOptions creation to have a Title for context.
The reason is that default parser behavior may vary with the type of page. The special case for conversion tables in
daniel added a comment.
The longer I think about this, the more I want ParserOptions creation to have a Title for context.
The reason is that default parser behavior may vary with the type of page. The special case for conversion tables in WikiPage::makeParserOptions() is the point in case.
We
gerritbot added a comment.
Change 445225 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Remove unreachable code path
https://gerrit.wikimedia.org/r/445225TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445226 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/SpamBlacklist@master] Replace deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445226TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445224 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/ProofreadPage@master] Replace deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445224TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445223 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/ParsoidBatchAPI@master] Avoid deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445223TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445225 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/Scribunto@master] Remove unreacahable code path
https://gerrit.wikimedia.org/r/445225TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445228 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/Wikibase@master] Replace deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445228TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445227 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/TemplateStyles@master] Replace deprecated ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445227TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445221 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Hard-deprecate ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445221TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
gerritbot added a comment.
Change 445220 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Deprecate ContentHandler::makeParserOptions()
https://gerrit.wikimedia.org/r/445220TASK DETAILhttps://phabricator.wikimedia.org/T194263EMAIL
Anomie added a comment.
ParserOptions::newCanonical() already exists, taking a User and a Language for the 'userlang' option. If they're not passed, they currently default to $wgUser and $wgLang. Now that I think about it fresh, I think I'll just extend that method to accept an IContextSource or
daniel added a comment.
You are right, static factory methods on ParserOptions are probably the best choice for now. Ideally, ParserOutput is a plain value object, then we don't even need a factory - but even if we do, we can add that later.
We definitely want something like
Anomie added a comment.
For now, it probably OK to move the logic to WikiPage::makeParserOptions().
I'd be fine with that, except we don't normally have a WikiPage where we need one. We usually do have a Title, but WikiPage::factory() chokes on Special-page titles and the like making it hard to
21 matches
Mail list logo
