[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

gerritbot added a comment. Change 449507 abandoned by Lucas Werkmeister (WMDE): Ignore auto-summary key if equal to language code https://gerrit.wikimedia.org/r/449507 TASK DETAIL https://phabricator.wikimedia.org/T196290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

gerritbot added a comment. Change 451651 abandoned by Hoo man: Change edit summary for Gloss changes Reason: duplicate https://gerrit.wikimedia.org/r/451651TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ho

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

gerritbot added a comment. Change 451270 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Update i18n message for changing glosses https://gerrit.wikimedia.org/r/451270TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

gerritbot added a comment. Change 451270 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Update i18n message for changing glosses https://gerrit.wikimedia.org/r/451270TASK DETAILhttps://phabricator.wikime

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

hoo added a comment. Ok, so I just looked into this again and removing the redundant languages after the summary is not easily possible. These are needed as it's possible to add/remove/change several glosses at once and still be able to denote their respective languages. If we want a nicer solutio

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

gerritbot added a comment. Change 451651 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/WikibaseLexeme@master] Change edit summary for Gloss changes https://gerrit.wikimedia.org/r/451651TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

hoo added a comment. Hm, the message key for this is wikibase-lexeme-summary-set-sense-glosses (which is in line with wikibase-lexeme-summary-set-form-representations for form representations). Form representation change edit summaries currently render as: Changed representation of Form L1-F1: de-a

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

Lydia_Pintscher added a comment. The edit summary for changing a Gloss is still wrong. It says "Set [de] gloss of Sense L1-S1: de: foo" instead of "Changed [de] gloss of Sense L1-S1: de: foo". Rest looks good.TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.w

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

gerritbot added a comment. Change 449507 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Ignore auto-summary key if equal to language code https://gerrit.wikimedia.org/r/449507TASK DETAILhttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

Lucas_Werkmeister_WMDE added a comment. Note that the language code is also included in the “auto summary” part of the message, for forms as well. For example: Added representation of Form L123-F3: en: sandbox I suppose when the language code is included in the “auto comment” part, we should get

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

Lydia_Pintscher added a comment. Ok then go with [en] etc and we'll do a proper cleanup for all these messages in a different ticket.TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lyd

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

Lucas_Werkmeister_WMDE added a comment. I think it’s just inconsistently applied, yes. wikibase-entity-summary-wbsetlabel-set is overridden, -add and -remove aren’t.TASK DETAILhttps://phabricator.wikimedia.org/T196290EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

Lydia_Pintscher added a comment. Here are three edits with inconsistent language handling in the edit summary: https://www.wikidata.org/w/index.php?title=Q4115189&diff=718855785&oldid=718625723 https://www.wikidata.org/w/index.php?title=Q18609189&curid=20141134&diff=718854115&oldid=435807537 http

[Wikidata-bugs] [Maniphest] [Commented On] T196290: See summary of edit including Senses

Lucas_Werkmeister_WMDE added a comment. Okay, so the way that “added French label” works on Wikidata is that the message wikibase-entity-summary-wbsetlabel-set is locally overridden there, with the following content: Changed {{#language:$2|{{int:Lang label {{#language:}} is a parser function