debt added a comment.
Moving this to done, but it'll actually go out on the train this week.TASK DETAILhttps://phabricator.wikimedia.org/T198091EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: debtCc: Aklapper, gerritbot, EBernhardson, EBjune, Smalyshev, Addsho
gerritbot added a comment.
Change 442912 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Catch bad lookups and report them
https://gerrit.wikimedia.org/r/442912TASK DETAILhttps://phabricator.wikimedia.org/T198091EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailp
gerritbot added a comment.
Change 442912 had a related patch set uploaded (by Addshore; owner: Smalyshev):
[mediawiki/extensions/Wikibase@master] Catch bad lookups and report them
https://gerrit.wikimedia.org/r/442912TASK DETAILhttps://phabricator.wikimedia.org/T198091EMAIL PREFERENCEShttps://phab
Smalyshev added a comment.
Just noticed - most of these errors, except for 4, are from testwikidatawiki. That explains weird properties. Since having deleted property on the data is still a legit case, we probably should log it but otherwise ignore it. If it becomes too noisy, we can remove logging
Smalyshev added a comment.
Digging even more back into the logs, I see stuff like:
[a1fe912ff31262409ada4e58] /rpc/RunSingleJob.php Wikibase\DataModel\Services\Lookup\PropertyDataTypeLookupException from line 50 of /srv/mediawiki/php-1.32.0-wmf.7/vendor/wikibase/data-model-services/src/Lookup/En
Smalyshev added a comment.
Weird thing is that these errors stopped at 2018-06-27T01:07:29 and don't seem to be happening anymore. Also, failed lookup is always for P400 - which is weird since if the lookup has been generally broken, wouldn't lookups for other properties fail at least occasionally?
Smalyshev added a comment.
Hmm property lookups seem to be old code and P400 is a legit property. Not sure why it would fail. I'll try to dig a bit more into it and maybe add some wrapping so exception does not propagate. In general it seems to make sense that if some of the data is unavailable we
