gerritbot added a comment.
Change 450551 merged by jenkins-bot:
[mediawiki/core@master] Add safeguard against loading content across wikis.
https://gerrit.wikimedia.org/r/450551TASK DETAILhttps://phabricator.wikimedia.org/T201194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/ema
gerritbot added a comment.
Change 450551 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Add safeguard against loading content across wikis.
https://gerrit.wikimedia.org/r/450551TASK DETAILhttps://phabricator.wikimedia.org/T201194EMAIL PREFERENC
gerritbot added a comment.
Change 450477 abandoned by Daniel Kinzler:
Warn about unexpected content models when loading entities.
Reason:
Redundant per If94f8cb11
https://gerrit.wikimedia.org/r/450477TASK DETAILhttps://phabricator.wikimedia.org/T201194EMAIL PREFERENCEShttps://phabricator.wikimedi
WMDE-leszek added a comment.
With the reverted merged and https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?debug=true looking OK, I guess the priority can be lowered?TASK DETAILhttps://phabricator.wikimedia.org/T201194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefer
gerritbot added a comment.
Change 450476 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "Use PageUpdater & RevisionStore in Wikibase"
https://gerrit.wikimedia.org/r/450476TASK DETAILhttps://phabricator.wikimedia.org/T201194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/se
gerritbot added a comment.
Change 450477 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Warn about unexpected content models when loading entities.
https://gerrit.wikimedia.org/r/450477TASK DETAILhttps://phabricator.wikimedia.org
gerritbot added a comment.
Change 450476 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Revert "Use PageUpdater & RevisionStore in Wikibase"
https://gerrit.wikimedia.org/r/450476TASK DETAILhttps://phabricator.wikimedia.org/T20119
daniel added a comment.
Ok, confirmed locally: this is caused by the new WikiPageEntityRevisionLookup code.
Analysis: RevisionStore loads the correct revision content from the correct database (wikidatawiki), but since rev_content_model is NULL in the database, it falls back to using the default c
daniel added a comment.
At a quick guess, the new code in WikiPageEntityRevisionLookup does not work correctly for cross-wiki access. Seems like I did not test this thoroughly enough. I'll try to get a fix in by tomorrow. If I don't manage that, we'll have to revert https://gerrit.wikimedia.org/r/c
greg added a comment.
Marking as blocking the next train just to keep track of this.TASK DETAILhttps://phabricator.wikimedia.org/T201194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gregCc: greg, Jakob_WMDE, Pablo-WMDE, Niharika, TerraCodes, Liuxinyu970226,
Niharika added a comment.
The error seems to only happen on the main page but not https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences (and presumably other pages)TASK DETAILhttps://phabricator.wikimedia.org/T201194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpre
11 matches
Mail list logo