gerritbot added a comment.
Change 460891 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Reassign statement IDs when adding a sense
https://gerrit.wikimedia.org/r/460891TASK DETAILhttps://phabricator.wikimedia.org/T201605EMAIL
gerritbot added a comment.
Change 461112 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Clone source entity in ChangeOp{Form,Sense}Clone
https://gerrit.wikimedia.org/r/461112TASK DETAILhttps://phabricator.wikimedia.org/T201605EMAIL
gerritbot added a comment.
Change 461112 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Clone source entity in ChangeOp{Form,Sense}Clone
https://gerrit.wikimedia.org/r/461112TASK
Lucas_Werkmeister_WMDE added a comment.
Weird, when I merge a lexeme that has only forms, but no senses, I don’t even get that separate edit (“merged lexeme into Lxxx”), only the final “redirected to Lxxx” edit.TASK DETAILhttps://phabricator.wikimedia.org/T201605EMAIL
Lucas_Werkmeister_WMDE added a comment.
In T201605#4586498, @Lydia_Pintscher wrote:
https://wikidata.beta.wmflabs.org/w/index.php?title=Lexeme:L67=1061436=1061435 also looks kinda suspicious to me.
I think this is related to the same problem – the statements have different IDs before and after
gerritbot added a comment.
Change 460891 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Reassign statement IDs when adding a sense
https://gerrit.wikimedia.org/r/460891TASK
Jakob_WMDE added a comment.
It appears that the statement on L1-S8 lost its GUID during the merge. ChangeOpFormAdd has some logic to (re)generate GUIDs when adding a form with existing statements. It looks like this may be missing for senses.
wbgetentities says
{
"id": "L1-S8",
"glosses":
Lydia_Pintscher added a comment.
https://wikidata.beta.wmflabs.org/w/index.php?title=Lexeme:L67=1061436=1061435 also looks kinda suspicious to me.TASK DETAILhttps://phabricator.wikimedia.org/T201605EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Lydia_Pintscher added a comment.
Yeah that could work! Let's see how much of a problem it becomes and then file a ticket for it if needed.TASK DETAILhttps://phabricator.wikimedia.org/T201605EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc:
Bugreporter added a comment.
As each senses may have some statements, we may create a new special page Special:MergeSense to handle that.TASK DETAILhttps://phabricator.wikimedia.org/T201605EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BugreporterCc: Denny,
Bugreporter added a comment.
We can implement a kind of "internal redirect": replace the merged sense with a kind of "stub" entity including a "symbolic" link to other senses (indicating the content is located in other senses), and existing links will not be brokenTASK
11 matches
Mail list logo
