[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-16 Thread gerritbot
gerritbot added a comment. Change 452677 merged by jenkins-bot: [mediawiki/core@master] selenium: undo page https://gerrit.wikimedia.org/r/452677TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-16 Thread WMDE-leszek
WMDE-leszek added a comment. With https://gerrit.wikimedia.org/r/452915 merged the T201928 should no longer be triggering failures that were blocking ContrentTranslation. @Nikerabbit could you verify that this is the case (and at very least lower the priority of this task, although probably is

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-15 Thread gerritbot
gerritbot added a comment. Change 452915 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Replace browser test with integration test https://gerrit.wikimedia.org/r/452915TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-15 Thread gerritbot
gerritbot added a comment. Change 452915 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/WikibaseLexeme@master] Replace browser test with integration test https://gerrit.wikimedia.org/r/452915TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-15 Thread Addshore
Addshore added a comment. In T201901#4504210, @WMDE-leszek wrote: Re merging I am note sure. Could be done, although there is some "conceptual" difference, as I tried to say in the last sentence in the row above. If merging tasks makes it easier to manage and figure out what should be fixed (and

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-15 Thread WMDE-leszek
WMDE-leszek added a comment. @Deskana I believe we hope the other one. I.e. that fixing T201928 would also fix this one :) Basically T201928 is a bug, and what this task covers is more of the influence of this bug. Re merging I am note sure. Could be done, although there is some "conceptual"

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-14 Thread gerritbot
gerritbot added a comment. Change 452666 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Dismiss Visual Editor modal before undoing lexeme changes https://gerrit.wikimedia.org/r/452666TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-14 Thread gerritbot
gerritbot added a comment. Change 452677 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/core@master] selenium: undo page https://gerrit.wikimedia.org/r/452677TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-14 Thread gerritbot
gerritbot added a comment. Change 452667 abandoned by Jakob: DNM Debugging T201901 https://gerrit.wikimedia.org/r/452667TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-14 Thread gerritbot
gerritbot added a comment. Change 452667 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/ContentTranslation@master] DNM Debugging T201901 https://gerrit.wikimedia.org/r/452667TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-14 Thread gerritbot
gerritbot added a comment. Change 452666 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/WikibaseLexeme@master] Dismiss Visual Editor modal before undoing lexeme changes https://gerrit.wikimedia.org/r/452666TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-14 Thread Addshore
Addshore added a comment. In T201901#4501182, @Addshore wrote: This will again be as a result of T200508 being completed yesterday So, it appears this is indeed because Wikibase now pulls in Lexeme for CI, and ContentTranslation pulls in Wikibase (thus also Lexeme). ContentTranslation also

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I get the same dialog on Wikidata in a private window, so it must not be a very recent change. F24923831: Screenshot_2018-08-14 Undoing edit to Q4115189 - Wikidata.pngTASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. That’s the VisualEditor welcome (i18n) – VE probably shouldn’t be running on that page, should it?TASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T201901: Selenium test Lexeme:Undoing removes grammatical features fails

2018-08-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. From the screenshot it looks like a “welcome to $wiki” banner is blocking the “submit” button: F24923387: ERROR_chrome_2018-08-14T08-22-26.153Z.pngTASK DETAILhttps://phabricator.wikimedia.org/T201901EMAIL