gerritbot added a comment.
Change 472181 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make nonexisting item test agnostic of item namespace
https://gerrit.wikimedia.org/r/472181TASK DETAILhttps://phabricator.wikimedia.org/T204205EMAIL
gerritbot added a comment.
Change 472181 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Make nonexisting item test agnostic of item namespace
https://gerrit.wikimedia.org/r/472181TASK
Addshore added a comment.
Possible solutions considered:
Get settings from the API? (There isn't an obvious API)
Pass in an ENV var stating what the namespace is? (similar to the ruby ones)
try to get the namespace from the JS via the browser in the tests
Be more relaxed about how we check /
zeljkofilipin added a comment.
As far as I am concerned, it's fine not to run a failing test, until it's fixed. See how it's done for core: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/457854TASK DETAILhttps://phabricator.wikimedia.org/T204205EMAIL
Addshore added a comment.
In T204205#4580022, @zeljkofilipin wrote:
@Ladsgroup @Addshore do you know what is the problem?
This is down to the configuration / hardcoding of the namespace.
The test does this:
NonExistingItemPage.open();
// Which does the following internally page.openTitle(
