[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

gerritbot added a comment. Change 463264 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] When an invalid language code is requested use 'und' instead https://gerrit.wikimedia.org/r/463264TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Krinkle added a comment. I'm not sure it is used anywhere, but it just stands for "language undetermined", which is the case when a user passes random crap in there? Yes, sorry for the confusion, I wasn't disagreeing on it being a good way to handle this kind of input. That makes perfect sense.

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

gerritbot added a comment. Change 463323 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Switch Wikibase.NewItemIdFormatter log to error from critical https://gerrit.wikimedia.org/r/463323TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

gerritbot added a comment. Change 463323 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Switch Wikibase.NewItemIdFormatter log to error from critical https://gerrit.wikimedia.org/r/463323TASK

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Krinkle added a comment. @Jonas The uselang-hacks represent a legacy feature for the community, originally for Commons but probably other wikis as well. Examples: https://commons.wikimedia.org/w/index.php?title=Commons:Hochladen=de

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-09-27T16:34:52Z] Synchronized wmf-config/InitialiseSettings.php: T204791 (duration: 00m 57s)TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

gerritbot added a comment. Change 463307 merged by jenkins-bot: [operations/mediawiki-config@master] logging: Disable 'Wikibase.NewItemIdFormatter' channel https://gerrit.wikimedia.org/r/463307TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

gerritbot added a comment. Change 463307 had a related patch set uploaded (by Krinkle; owner: Krinkle): [operations/mediawiki-config@master] logging: Disable 'Wikibase.NewItemIdFormatter' channel https://gerrit.wikimedia.org/r/463307TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Jonas added a comment. Interestingly falls back to English but ⧼lang⧽ not. Also Language class has interesting special features protected static function newFromCode( $code, $fallback = false ) { if ( !self::isValidCode( $code ) ) { throw new MWException( "Invalid language code

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

gerritbot added a comment. Change 463264 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)): [mediawiki/extensions/Wikibase@master] When an invalid language code is requested use 'und' instead https://gerrit.wikimedia.org/r/463264TASK

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Lucas_Werkmeister_WMDE added a comment. One option would be to treat all invalid language codes as und (“undetermined”).TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc:

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Lucas_Werkmeister_WMDE added a comment. This might be coming from a misbehaving gadget, lua module, etc. on a client wiki, which might try to do something like this: // ... url += '=' + mw.message('lang').escaped(); MediaWiki:Lang is a message translating to the current user language on some,

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Lucas_Werkmeister_WMDE added a comment. When an invalid language code is requested some other default formatting will be used. << @Lydia_Pintscher to decide this. Decision: treat it as an unknown language that falls back to English, just like e. g. uselang=1234. (Note that language fallback

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

gerritbot added a comment. Change 461624 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff, Throw exception with key when invalid https://gerrit.wikimedia.org/r/461624TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

gerritbot added a comment. Change 461624 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff, Throw exception with key when invalid https://gerrit.wikimedia.org/r/461624TASK

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Addshore added a comment. Wikibase assumes that the language code in the ParserOptions is valid, but the ParserOptions will happily have whatever language the user provided. /var/www/mediawiki/extensions/Wikibase/repo/includes/Content/EntityContent.php:272: object(Language)[652] public

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Addshore added a comment. Looking at the request URLs this seems to be users requesting invalid language codes, and the code makes it all the way into the cache key, that is then invalid as it contains bad chars. Example: https://www.wikidata.org/wiki/Q101971?uselang=%E2%A7%BClang%E2%A7%BD Each

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

Krinkle added a comment. This is the first time I've seen a log error in MediaWiki with severity CRITICAL. Given that this issue has been around for over 30 days and that the urls it applies to all seem to render fine, this is probably incorrect use of this severity.TASK