[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2019-01-08 Thread gerritbot
gerritbot added a comment. Change 468972 abandoned by Tarrow: DNM Testing if ServicesTest runs https://gerrit.wikimedia.org/r/468972TASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc:

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-11-05 Thread gerritbot
gerritbot added a comment. Change 471742 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Test possible global values in ServiceWiring https://gerrit.wikimedia.org/r/471742TASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-11-05 Thread Tarrow
Tarrow added a comment. Whoops, we passed like 'ships in the night' (or should that be 'at lunch'). There is a another patch that should make sure that whatever the globals are set we check that the Wiring will result in a service we can use (or a dummy one we'll ignore).TASK

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-11-05 Thread Tarrow
Tarrow added a comment. The two services that are obviously switched in the service wiring based on globals are ResultSource and SparqlHelper. I've uploaded a patch to at least be sure that the various possible settings are tested. I wonder if the solution may be to remove the logic from the

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-11-05 Thread gerritbot
gerritbot added a comment. Change 471742 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/WikibaseQualityConstraints@master] Test possible global values in ServiceWiring https://gerrit.wikimedia.org/r/471742TASK

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-11-01 Thread gerritbot
gerritbot added a comment. Change 471002 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/WikibaseQualityConstraints@master] Cache constraints checks by default https://gerrit.wikimedia.org/r/471002TASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-11-01 Thread Addshore
Addshore added a comment. In T206205#4691482, @Lucas_Werkmeister_WMDE wrote: Ah, I see. I figure we could default that config variable to true by now, anyways… any reason not to? I like the sound of this!TASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-10-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Ah, I see. I figure we could default that config variable to true by now, anyways… any reason not to?TASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow,

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-10-24 Thread Tarrow
Tarrow added a comment. It's not tested because the erroring codepath is only hit if WBQualityConstraintsCacheCheckConstraintsResults config option is set to trueTASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-10-23 Thread Tarrow
Tarrow added a comment. It appears to be that the Services tests are running both locally and on CI. Looking through logstash/kibana it seems that all the errors are coming this sort of path: #0 /srv/mediawiki/php-1.32.0-wmf.24/extensions/WikibaseQualityConstraints/src/ServiceWiring.php(249):

[Wikidata-bugs] [Maniphest] [Commented On] T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints

2018-10-22 Thread gerritbot
gerritbot added a comment. Change 468972 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/WikibaseQualityConstraints@master] DNM Testing if ServicesTest runs https://gerrit.wikimedia.org/r/468972TASK DETAILhttps://phabricator.wikimedia.org/T206205EMAIL