Lydia_Pintscher added a comment.
\o/TASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDE, Lydia_PintscherCc: Addshore, gerritbot, KaMan, Jakob_WMDE, Lucas_Werkmeister_WMDE, Greta_Doci_WMDE,
gerritbot added a comment.
Change 482307 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] width and padding was changed so glosses of all senses to be in the same line vertically
https://gerrit.wikimedia.org/r/482307TASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL
Addshore added a comment.
Patch looks good, for me while testing locally this has gone from this:
F27791200: image.png
To this:
F27791204: image.png
+2ed :)TASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 482307 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi):
[mediawiki/extensions/WikibaseLexeme@master] width and padding was changed so glosses of all senses to be in the same line vertically
https://gerrit.wikimedia.org/r/482307TASK
Lydia_Pintscher added a comment.
This one please :)
F27683926: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDE, Lydia_PintscherCc: KaMan, Jakob_WMDE, Lucas_Werkmeister_WMDE,
Greta_Doci_WMDE added a comment.
If we want to go ahead with Lucas idea we should also increasing the width value up to 220px, so we would only have the longest language to be wrapped.
F27683926: image.png
Otherwise if we leave it 'width: 100px' it will look like the pic below and its confusing.
Lucas_Werkmeister_WMDE added a comment.
Note: if we want to solve this by wrapping the language name (not saying we should, just an option), we could add some indent to the language name to make it clear that the wrapped lines are not new languages:
padding-left: 1em;
text-indent: -1em;
Greta_Doci_WMDE added a comment.
More testing: Looks like fixing width will not resolve our problem completely. As seen in the screenshot below, all the other glosses are aligned depending on the longest language name.
F27557315: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL
Lucas_Werkmeister_WMDE added a comment.
That screenshot also shows that the language name and gloss text have slightly different baselines :/TASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDE,
Greta_Doci_WMDE added a comment.
In T207401#4823831, @Michael wrote:
@Greta_Doci_WMDE @Lydia_Pintscher
This is an example where long language names are already breaking the layout: https://www.wikidata.org/wiki/Lexeme:L3338#S1
Yep, this happens in all versions of browsers, not only at the
Michael added a comment.
@Greta_Doci_WMDE @Lydia_Pintscher
This is an example where long language names are already breaking the layout: https://www.wikidata.org/wiki/Lexeme:L3338#S1
Setting the width to 100px and removing max-width and min-width as mentioned above, fixes that problem as
Michael added a comment.
Side-note: I noticed that the language code and the gloss value are not perfectly vertically aligned. The gloss value has some vertical 1px padding that the language code is missing and that causes the slight misalignment.TASK
Michael added a comment.
This is a problem with table layouting in IE11, Edge and some older Chrome versions.
From some preliminary testing on IE 11, it seems like adding an explicit width attribute to the first table cell (i.e. .wikibase-lexeme-sense-gloss-language) resolves that problem.
Lydia_Pintscher added a comment.
-.-
Nikki tried Vivaldi 1.14, Edge and IE11 and I tried Chromium. I can reproduce it logged in and logged out.TASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Ladsgroup added a comment.
I can't reproduce this issue on Firefox or Chrome. Can you give more details on what is your browser?
F27317353: image.png
F27317357: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL
15 matches
Mail list logo
