gerritbot added a comment.
Change 473585 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix the fragment of old-style links to subentities
https://gerrit.wikimedia.org/r/473585TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL
gerritbot added a comment.
Change 473587 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix the fragment of old-style links to forms
https://gerrit.wikimedia.org/r/473587TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL
gerritbot added a comment.
Change 473586 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Don’t detect fragments of form IDs of other lexemes
https://gerrit.wikimedia.org/r/473586TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL
Lucas_Werkmeister_WMDE added a comment.
Alright, I’ve uploaded one possible approach:
Wikibase
WikibaseLexeme
It’s not the nicest thing in the world, but I think it’s acceptable. Alternative suggestions are welcome, though.
Related but independent is another fix in WikibaseLexeme.TASK
gerritbot added a comment.
Change 473586 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Don’t detect fragments of form IDs of other lexemes
https://gerrit.wikimedia.org/r/473586TASK
gerritbot added a comment.
Change 473587 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix the fragment of old-style links to forms
https://gerrit.wikimedia.org/r/473587TASK
gerritbot added a comment.
Change 473585 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix the fragment of old-style links to subentities
https://gerrit.wikimedia.org/r/473585TASK
Lucas_Werkmeister_WMDE added a comment.
In T208423#4731782, @Lucas_Werkmeister_WMDE wrote:
The component which prettifies entity links in edit summaries hasn’t been updated for the new form anchors yet, apparently.
Could that component also be used to update the anchor from e. g. #L41-F1 to #F1,
gerritbot added a comment.
Change 472953 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Create lexeme id from fragment
https://gerrit.wikimedia.org/r/472953TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL
gerritbot added a comment.
Change 472953 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Create lexeme id from fragment
https://gerrit.wikimedia.org/r/472953TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL
Lucas_Werkmeister_WMDE added a comment.
I looked a bit into this as well, and I think LexemeHandler::getIdForTitle needs to be updated. It currently tries to “parse” the fragment as an ID; in addition, it should also attempt to parse text + fragment as an ID.TASK
Michael added a comment.
Results of the investigation so far:
The relevant pattern is in WikibaseLexeme/src/Domain/Model/FormId.php:
const PATTERN = '/^L[1-9]\d*-F[1-9]\d*\z/';
However, simply removing the first part of the pattern breaks
Lucas_Werkmeister_WMDE added a comment.
I actually noticed a different problem on L42’s history on testwikidata:
(Created claim: lexeme form of choice (P1): merge target/merge source/foo (L103)) (undo)
(Created claim: lexeme form of choice (P1): MediaWikis (L41-F1)) (undo) (restore)
Michael added a comment.
Turns out the wikitext for the comment from the summary is directly in the database as wikitext. Thus is seems not savely possible to fix the old entries.
Screenshots are from system recreating the problem:
F27096357: Screenshot_2018-11-07 phpmyadmin mw localhost 8080
Michael added a comment.
It seems this is only a problem with historic entries. New ones are fine-ish: https://test.wikidata.org/w/index.php?title=Lexeme:L42="">TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL
15 matches
Mail list logo
