gerritbot added a comment.
Change 490360 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove oojs-ui/ icons
https://gerrit.wikimedia.org/r/490360
TASK DETAIL
https://phabricator.wikimedia.org/T209259
EMAIL PREFERENCES
gerritbot added a comment.
Change 485991 **merged** by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Replace icon path and update
icons accordingly to Wikibase
https://gerrit.wikimedia.org/r/485991
TASK DETAIL
https://phabricator.wikimedia.org/T209259
EMAIL PREFERENCES
Volker_E added a comment.
Excellent, thanks @Lucas_Werkmeister_WMDE!
TASK DETAIL
https://phabricator.wikimedia.org/T209259
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Volker_E
Cc: Lucas_Werkmeister_WMDE, Charlie_WMDE, Greta_Doci_WMDE,
Volker_E added a comment.
@Lydia_Pintscher Due to the path dependency someone still needs to review and
merge WikibaseLexeme patch provided at
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/485991/
TASK DETAIL
https://phabricator.wikimedia.org/T209259
EMAIL
Lydia_Pintscher added a comment.
Is there anything left to do here now? I'm sorry I get a bit lost in the
patches.
TASK DETAIL
https://phabricator.wikimedia.org/T209259
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Volker_E, Lydia_Pintscher
gerritbot added a comment.
Change 490359 abandoned by Lucas Werkmeister (WMDE):
Update for new Wikibase icon location
Reason:
I forgot this change already existed as I556d9a0b64.
https://gerrit.wikimedia.org/r/490359TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL
gerritbot added a comment.
Change 473155 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update outdated icons with latest standard ones
https://gerrit.wikimedia.org/r/473155TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL
gerritbot added a comment.
Change 490358 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Clean up CSS comments
https://gerrit.wikimedia.org/r/490358TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL
gerritbot added a comment.
Change 490360 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: VolkerE):
[mediawiki/extensions/Wikibase@master] Remove oojs-ui/ icons
https://gerrit.wikimedia.org/r/490360TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL
gerritbot added a comment.
Change 490359 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Update for new Wikibase icon location
https://gerrit.wikimedia.org/r/490359TASK
gerritbot added a comment.
Change 490358 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: VolkerE):
[mediawiki/extensions/Wikibase@master] Clean up CSS comments
https://gerrit.wikimedia.org/r/490358TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL
gerritbot added a comment.
Change 485991 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/WikibaseLexeme@master] Replace icon path and update icons accordingly to Wikibase
https://gerrit.wikimedia.org/r/485991TASK
gerritbot added a comment.
Change 483124 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update help icon with the new one
https://gerrit.wikimedia.org/r/483124TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL
Volker_E added a comment.
In T209259#4753319, @Greta_Doci_WMDE wrote:
@Jan_Dittrich @Volker_E I pulled https://gerrit.wikimedia.org/r/473155.
I checked the look of the item page with Jan, we noted that the pencil icon was changed which is fine. In the issue description you also mention Save and
Greta_Doci_WMDE added a comment.
@Charlie_WMDE, it is already finished by @Volker_E, he also uploaded the patch with the new changes :)TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_E,
Charlie_WMDE added a comment.
@Greta_Doci_WMDE does that help you to finish the task?TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_E, Charlie_WMDECc: Charlie_WMDE, Greta_Doci_WMDE, gerritbot,
Charlie_WMDE added a comment.
Thank you for @Volker_E !TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_E, Charlie_WMDECc: Charlie_WMDE, Greta_Doci_WMDE, gerritbot, Addshore, Lydia_Pintscher,
Volker_E added a comment.
That's a proposal with amended icon, size, background-size, margin and opacity:
F27834338: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_ECc: Charlie_WMDE,
Greta_Doci_WMDE added a comment.
@Charlie_WMDE @Volker_E, I changed the help icon according to your suggestions. I removed the hover, because as I understood the new versions have no hover. But, if I missed something, let me know and I add that back.
Also, I changed the width and height according
gerritbot added a comment.
Change 483123 abandoned by Greta WMDE:
Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase into review/volkere/replace-wbtoolbar-icons-with-standard-T209259
https://gerrit.wikimedia.org/r/483123TASK
gerritbot added a comment.
Change 483123 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi):
[mediawiki/extensions/Wikibase@master] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase into
gerritbot added a comment.
Change 483124 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi):
[mediawiki/extensions/Wikibase@master] Update help-icon with the new one. -Also hover was removed since there was no icon for it. -width and height was changed according to the new icon
Volker_E added a comment.
@Charlie_WMDE Indeed, 'helpNotice' is the best choice here. 'helpNotice' is used where a focus on interactive area of the help element is useful, while 'help' is working well in a toolbar or framed button.TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL
Charlie_WMDE added a comment.
@Greta_Doci_WMDE
since the help icon is not an overall icon but used with every statement etc. it should stay with the other icons. We don't seem to have an overall help icon on the page that is visible at all times. If we need something like that is a different
Greta_Doci_WMDE added a comment.
Is the background-size that @Volker_E mentioned correct? I'm not sure what was meant by that.
Yes, background-sze is 16X16
Another point: I would suggest also updating the help icon to OOUI. I'm not sure why that wasn't part of the task description. I would use
Charlie_WMDE added a comment.
Hi @Greta_Doci_WMDE, sorry for not replying for so long.
save and cancel do indeed seem like the correct icons. Is the background-size that @Volker_E mentioned correct? I'm not sure what was meant by that.
Another point: I would suggest also updating the help icon
Greta_Doci_WMDE added a comment.
@Jan_Dittrich @Volker_E I pulled https://gerrit.wikimedia.org/r/473155.
I checked the look of the item page with Jan, we noted that the pencil icon was changed which is fine. In the issue description you also mention Save and Cancel icons, seems that they have
Volker_E added a comment.
@Jan_Dittrich While I'm working at this, I'd also suggest to replace the help icon seen in the first screenshot with 'helpNotice' of OOUI – asking as it hasn't been standardized like the 5 other icons before.TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL
gerritbot added a comment.
Change 473155 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Wikibase@master] Update outdated icons with latest standard ones
https://gerrit.wikimedia.org/r/473155TASK DETAILhttps://phabricator.wikimedia.org/T209259EMAIL
29 matches
Mail list logo
