[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-03-06 Thread gerritbot
gerritbot added a comment. Change 487498 abandoned by Lucas Werkmeister (WMDE): Add use case for SchemaEditAction Reason: very outdated by now https://gerrit.wikimedia.org/r/487498 TASK DETAIL https://phabricator.wikimedia.org/T215029 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-02-07 Thread Tarrow
Tarrow added a comment. Looks like maybe this is now "done"? given that we have a single user case for creation and we think we don't need others?TASK DETAILhttps://phabricator.wikimedia.org/T215029EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc:

[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-02-05 Thread gerritbot
gerritbot added a comment. Change 487497 abandoned by Michael Große: Extract UseCase to provide Content's parser output Reason: As discussed, this is overengineering it and the current situation of doing the deserialization in the WikibaseSchemaContent is good enough. There is not much value that

[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-02-01 Thread gerritbot
gerritbot added a comment. Change 487354 merged by jenkins-bot: [mediawiki/extensions/WikibaseSchema@master] Extract the CreateSchema usecase https://gerrit.wikimedia.org/r/487354TASK DETAILhttps://phabricator.wikimedia.org/T215029EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-02-01 Thread gerritbot
gerritbot added a comment. Change 487498 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseSchema@master] Add use case for SchemaEditAction https://gerrit.wikimedia.org/r/487498TASK

[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-02-01 Thread gerritbot
gerritbot added a comment. Change 487497 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/WikibaseSchema@master] Extract UseCase to provide Content's parser output https://gerrit.wikimedia.org/r/487497TASK

[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-02-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I’ll try to write a use case for editing a schema. Specifically, I think it will be a use case just for submitting the edit, and loading the edit form would be separate. Let’s see where that gets me…TASK DETAILhttps://phabricator.wikimedia.org/T215029EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-02-01 Thread Michael
Michael added a comment. I'm going to implement the ViewSchema use-case nextTASK DETAILhttps://phabricator.wikimedia.org/T215029EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: gerritbot, RazShuty, JeroenDeDauw, hoo, Tarrow, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T215029: Refactor to use UseCases

2019-01-31 Thread gerritbot
gerritbot added a comment. Change 487354 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/WikibaseSchema@master] Extract the CreateSchema usecase https://gerrit.wikimedia.org/r/487354TASK DETAILhttps://phabricator.wikimedia.org/T215029EMAIL