gerritbot added a comment.
Change 491298 **merged** by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Toggle edit mode on primary,
and make state changes impossible during submit
https://gerrit.wikimedia.org/r/491298
TASK DETAIL
MarkTraceur added a comment.
@matthiasmullie this task is in the to-do column, but has a patch-for-review tag. Should we move it to "doing"?TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie,
gerritbot added a comment.
Change 491298 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Toggle edit mode on primary, and make state changes impossible during submit
https://gerrit.wikimedia.org/r/491298TASK
PDrouin-WMF added a comment.
Yeah, the original concepts allowed for that, but I think your solution
works, Cormac (going into edit mode once the user changes the primary state
and clicking publish or cancel).TASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL
Cparle added a comment.
Hmm ... you sure? Everything else requires the user to press 'publish'. Don't you think it'd be a bit odd for 'make primary' to be different?
To me it'd make most sense for the form to go into 'edit' mode once the user changes the state of one of primary - and then they
PDrouin-WMF added a comment.
It's less a link and more a button. Users should be able to mark a statement primary in read mode: https://wikimedia.invisionapp.com/d/main/#/console/15638944/324827163/previewTASK DETAILhttps://phabricator.wikimedia.org/T216241EMAIL
