[Wikidata-bugs] [Maniphest] [Commented On] T216728: Fix issue with LocalStorage holding outdated dataTypeStore when new data types are added to a wikibase

2019-03-20 Thread Addshore
Addshore added a comment. A future better way of solving this could be what is demonstrated in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/496622/ TASK DETAIL https://phabricator.wikimedia.org/T216728 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pan

[Wikidata-bugs] [Maniphest] [Commented On] T216728: Fix issue with LocalStorage holding outdated dataTypeStore when new data types are added to a wikibase

2019-03-06 Thread alaa_wmde
alaa_wmde added a comment. @Lydia_Pintscher I tried to test this (hackingly) when the change got on beta: modified my localStorage by hand to delete the new datatype, refreshed softly and tried to edit -> got the warning -> hard refreshed -> new data type was loaded again and I could edi

[Wikidata-bugs] [Maniphest] [Commented On] T216728: Fix issue with LocalStorage holding outdated dataTypeStore when new data types are added to a wikibase

2019-03-05 Thread gerritbot
gerritbot added a comment. Change 493702 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Warn to hard refresh page when datatypes in client side seems outdated https://gerrit.wikimedia.org/r/493702 TASK DETAIL https://phabricator.wikimedia.org/T216728 EMAIL PREFERE

[Wikidata-bugs] [Maniphest] [Commented On] T216728: Fix issue with LocalStorage holding outdated dataTypeStore when new data types are added to a wikibase

2019-03-01 Thread gerritbot
gerritbot added a comment. Change 493702 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Warn to hard refresh page when datatypes in client side seems outdated https://gerrit.wikimedia.org/r/493702 TASK DETAIL https://pha

[Wikidata-bugs] [Maniphest] [Commented On] T216728: Fix issue with LocalStorage holding outdated dataTypeStore when new data types are added to a wikibase

2019-03-01 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Yeah. Worksforme. TASK DETAIL https://phabricator.wikimedia.org/T216728 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Lydia_Pintscher Cc: Lydia_Pintscher, Aklapper, Addshore, alaa_wmde, Onmir, DannyS71

[Wikidata-bugs] [Maniphest] [Commented On] T216728: Fix issue with LocalStorage holding outdated dataTypeStore when new data types are added to a wikibase

2019-03-01 Thread alaa_wmde
alaa_wmde added a comment. @Lydia_Pintscher For now the quick fix on our side is to: 1. clear resource loader local storage on client side 2. prompt for the user to inform them they need to refresh the page to get an updated version of client. Sounds good? If yes, what copy would y

[Wikidata-bugs] [Maniphest] [Commented On] T216728: Fix issue with LocalStorage holding outdated dataTypeStore when new data types are added to a wikibase

2019-02-26 Thread alaa_wmde
alaa_wmde added a comment. Turns out that for Firefox we do not store resource loader response in local storage https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/resources/src/startup/mediawiki.js#2216 So on chrome the issue could be reproduced by followin

[Wikidata-bugs] [Maniphest] [Commented On] T216728: Fix issue with LocalStorage holding outdated dataTypeStore when new data types are added to a wikibase

2019-02-25 Thread alaa_wmde
alaa_wmde added a comment. @Addshore I've been investigating this one for a while. It seems that data types are not really stored in localStorage. I checked locally, on beta and on production but couldn't find any localStorage entries apart from very basic ones. Since I have the d