[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Krinkle added a comment. Seen on www.wikidata.org as well. - reqId: `4a83c7b9-dff6-4185-9a7d-b9dac050a1ab` - reqId: `a0bb4945-e080-4b41-a402-4c0edb562eff` - reqId: `081d5f57-ff6a-4f29-9971-fa722d7eae6b` - reqId: `df03dd06-c3cd-4853-b04a-dba00183800f` wikidatawiki /w/api

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Addshore added a comment. It's a shame we have cases of self redirects already in history that we have to try to deal with. @alaa_wmde thoughts? basically when coming from storage, we want to allow deserialization and serialization. when coming from a user we want to disallow it. T

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. The python scripts at the dump end are (mostly) protected against exceptions from MediaWiki generally and from this failure case in particular. Since we have problematic data in production I've re-opened the ticket so that the WikiBase issue can somehow be resolve

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Addshore added a comment. @ArielGlenn do I understand correctly however that this revision on wikidata.org is not an issue for dumps? We probably don't want to delete the revision from wikidata.org. A nice way to handle this in the UI might be to just accept the fact that the deseriali

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Krinkle added a comment. Still seen on 1.34-wmf.8. - XPam4gpAICsAAEeT0uER - GET testwikidatawiki /w/index.php?title=Q193394&redirect=no Fatal exception: `MWContentSerializationException from line 299 of /srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/lib/includes/Store/Enti

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. I'm fine with that approach. TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArielGlenn Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, ArielG

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Addshore added a comment. As this is just test wiki (and not a real wiki), and that this can no longer occur, perhaps we should just totally nuke the page from the db TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. Fixed for dumps but not within MediaWiki, i.e. https://test.wikidata.org/w/index.php?title=Q193394&redirect=no still gives an error. The bad entry needs to be removed or MW should do something nicer about such entries. TASK DETAIL https://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Krinkle added a comment. @ArielGlenn Is this resolved? TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, ArielGlenn,

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

gerritbot added a comment. Change 499402 **merged** by jenkins-bot: [mediawiki/core@master] redo: don't die producing xml files if rev text export conversion fails https://gerrit.wikimedia.org/r/499402 TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https:/

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

gerritbot added a comment. Change 499403 **merged** by jenkins-bot: [mediawiki/extensions/ActiveAbstract@master] don't die when revision serialization fails during link processing https://gerrit.wikimedia.org/r/499403 TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFE

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. In T217329#5073668 , @daniel wrote: > By the way: //$entityId and $targetId can not be the same// is somewhat alarming. It indicates that an invalid entity redirect exists in the database of testwikidatawiki.

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

daniel added a comment. If I understand correctly, the presence of these errors indicates invalid data in the database. This should not just be ignored. On the other hand, MediaWiki should not fatal out either. I suspect that the same error would not just occur while generating dumps, but al

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

daniel added a comment. By the way: //$entityId and $targetId can not be the same// is somewhat alarming. It indicates that an invalid entity redirect exists in the database of testwikidatawiki. I wonder how that happened. TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. I dislike both of the above patches and I don't have better ideas. I've run the abstracts job with these patches applied just to get the dump file produced for this run. TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

gerritbot added a comment. Change 499403 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn): [mediawiki/extensions/ActiveAbstract@master] don't die when revision serialization fails during link processing https://gerrit.wikimedia.org/r/499403 TASK DETAIL https://pha

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

gerritbot added a comment. Change 499402 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn): [mediawiki/core@master] redo: don't die producing xml files if rev text export conversion fails https://gerrit.wikimedia.org/r/499402 TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. Fixing me that gives me a failure later on: 2019-03-27 07:25:10: testwikidatawiki (ID 54422) 6 pages (32.9|363.6/sec all|curr), 7 revs (38.4|60.6/sec all|curr), ETA 2019-03-27 09:29:56 [max 287591] [e1818746fd28c6a70c6cf5a5] [no req] MWContentSerializat

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. And in fact that changeset (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/443608/) did break this again at exactly the point I asked about above. The new stacktrace: [0bda89b2b61b164a0232340b] [no req] MWContentSerializationException from line 299

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. Does XmlDumpWriter need a similar fix at a later stanza? Lines 298, 301 here: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/443608/46/includes/export/XmlDumpWriter.php Do we have a wiki configured such that this code path can be tested with a broken revision

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

gerritbot added a comment. Change 496348 **merged** by jenkins-bot: [mediawiki/core@master] don't die producing xml files if rev text export conversion fails https://gerrit.wikimedia.org/r/496348 TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Krinkle added a comment. (//Still seen on 1.33-wmf.21.//) [{exception_id}] {exception_url} MWContentSerializationException from line 299 of /srv/mediawiki/php-1.33.0-wmf.21/extensions/Wikibase/lib/includes/Store/EntityContentDataCodec.php: $entityId and $targetId can not be the same.

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. I've run the abstracts job on testwikidatawiki with the patch deployed manually on one of the snapshot hosts, and it was successful. TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

gerritbot added a comment. Change 496348 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn): [mediawiki/core@master] don't die producing xml files if rev text export conversion fails https://gerrit.wikimedia.org/r/496348 TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. I'll need to catch this in XmlDumpWriter after all. Too bad. dumpTextPass already does the right thing, so we'll do that too. TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferen

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. No joy. It must be triggered somewhere else too; I've imported the bad rev in a (very) old Wikidata installation and am now doing the update/upgrade dance so I can hack away at it locally. TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Addshore added a comment. How is this looking @ArielGlenn ? TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, hashar, Ariel

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

gerritbot added a comment. Change 494219 **merged** by jenkins-bot: [mediawiki/extensions/ActiveAbstract@master] when revision serialization fails, indicate the error in the xml https://gerrit.wikimedia.org/r/494219 TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERE

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. Is it possible that the current revision is serialized earlier when the page title is set up? I guess testing will show... TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

gerritbot added a comment. Change 494219 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn): [mediawiki/extensions/ActiveAbstract@master] when revision serialization fails, indicate the error in the xml https://gerrit.wikimedia.org/r/494219 TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. Perhaps there should be a maintenance script to delete such revisions; if we have them, other folks might have them also. I can see such a script getting the raw revision text for a specified id/batch of ids, checking that each one is a self-reference of that sort

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Addshore added a comment. We can probably catch the exception in EntityContentDataCodec::decodeRedirect and rethrow a MWContentSerializationException as is documented there. However im not sure if that will actually be handled further up the chain? EntityHandler::unserializeContent is docu

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. Groan can the error be handled differently then? I guess there's not much choice now... TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArielGlenn Cc: WMDE-lesz

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Lucas_Werkmeister_WMDE added a comment. Well, it’s impossible to delete the page via the API, that just returns the same error. I suppose we //could// delete it from the database directly, but that’s a pretty extreme solution. TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PR

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. If that sort of revision can't be created even by api, that's good enough for me. Someone on the MediaWiki side of things probably ought to weigh in on the case you mention above (fatal when viewing the deleted revision). TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Lucas_Werkmeister_WMDE added a comment. (Wikibase would still throw a fatal error if someone with appropriate privileges looked at the deleted revisions… not sure if that’s a big deal.) TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

ArielGlenn added a comment. It shouldn't exist, but MediaWiki/Wikibase should not throw a fatal exception when handling it, either. Or is it now impossible for such revision text to be saved? TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

Lucas_Werkmeister_WMDE added a comment. According to Quarry , Q193394 is the only self-redirecting item on test.wikidata.org, and there is no such item at all on www.wikidata.org. (Assuming my query is correct, of course.) Can we just delete the te

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki

ArielGlenn added a comment. Content from the pages-article dumps for this page/revision: Q193394 0 276101 461892 461881 2019-01-26T22:18:25Z GZWDer 91 /* restore:0||461880|GZWDer */

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki

ArielGlenn added a comment. https://test.wikidata.org/w/index.php?title=Q193394&action=history Last time this entry was touched was on Jan 26th, and it dumped properly during the Feb 1 run. So the rendering/serialization issue cropped up in a branch since then. TASK DETAIL https://phabric

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki

ArielGlenn added a comment. I lie. It persists through wmf.19 as well. I've got it down to a specific page. This command will reproduce the issue, run as the dumpsgen user from snapshot1005: /usr/bin/php7.2 /srv/mediawiki/multiversion/MWScript.php dumpBackup.php --wiki=testwikidatawik

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki

ArielGlenn added a comment. I am rerunning this with wmf.19 which is now the active branch for testwikidatawiki. It has passed the problematic point already. TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpref

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki

ArielGlenn added a comment. The last successful run was with MediaWiki 1.33.0-wmf.14 a couple of weeks back. TASK DETAIL https://phabricator.wikimedia.org/T217329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArielGlenn Cc: ArielGlenn, Nandana,