gerritbot added a comment.
Change 507025 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update termbox
https://gerrit.wikimedia.org/r/507025
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
gerritbot added a comment.
Change 507025 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Update termbox
https://gerrit.wikimedia.org/r/507025
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
gerritbot added a comment.
Change 506703 **merged** by jenkins-bot:
[wikibase/termbox@master] Fix input styles
https://gerrit.wikimedia.org/r/506703
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
gerritbot added a comment.
Change 506703 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Fix input styles
https://gerrit.wikimedia.org/r/506703
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
Hanna_Petruschat_WMDE added a comment.
Update to the "publish when clicking cancel" issue: It only shows the entry
directly after clicking cancel. When reloading, it's gone...
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
Hanna_Petruschat_WMDE added a comment.
Hi @Jakob_WMDE
I tested and found some issues. Some are not 100% related to this task, but
I'll note them all here to not forget them.
1. the border of the alias fields are higher than the other entry fields,
probably because there is padding
Jakob_WMDE added a comment.
@Hanna_Petruschat_WMDE thanks for reporting the missing feature yesterday.
There was indeed an accident and our code got rolled back. It's there again,
ready to be tested!
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
gerritbot added a comment.
Change 506133 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update termbox
https://gerrit.wikimedia.org/r/506133
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
gerritbot added a comment.
Change 506133 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Update termbox
https://gerrit.wikimedia.org/r/506133
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
gerritbot added a comment.
Change 504896 **merged** by jenkins-bot:
[wikibase/termbox@master] MonolingualFingerprintView: grow despite little
content
https://gerrit.wikimedia.org/r/504896
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
gerritbot added a comment.
Change 504896 had a related patch set uploaded (by Pablo Grass (WMDE); owner:
Pablo Grass (WMDE)):
[wikibase/termbox@master] MonolingualFingerprintView: grow despite little
content
https://gerrit.wikimedia.org/r/504896
TASK DETAIL
Hanna_Petruschat_WMDE added a comment.
@Pablo-WMDE I've the following suggestion:
Use the background highlight and define it like this
[ ] have the background set to Accent90 (#EAF3FF)
[ ] have the text entry in the focused input set to Base20 (#222)
This will keep up with WCAG
Pablo-WMDE added a comment.
Hello @Hanna_Petruschat_WMDE,
please find a screenshot of what chrome does by default in case of a sneak
peek into alias editing. The //aliases// component has a blue **border** (as
defined) because it has "focus within", the individual //alias// has the
Hanna_Petruschat_WMDE added a comment.
@Pablo-WMDE Thanks for the heads up. I totally agree to commit to this
especially looking towards accessibility (tab and highlight...)
I'm not 100% sure what it would look like and if it has implications on the
label and description being in focus
Pablo-WMDE added a comment.
Hello @Hanna_Petruschat_WMDE,
one more question about the individual alias input element - given that the
focus (blue border) is illustrated "one level up" from the individual alias (on
the aliases), should the individual alias really not signal focus at all
Lea_WMDE added a comment.
Updated the task description to have all acceptance criteria in there and not
also mixed into the comments
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lea_WMDE
Pablo-WMDE added a comment.
Leaving this here:
https://vuejs.org/v2/guide/components.html#Using-v-model-on-Components
TASK DETAIL
https://phabricator.wikimedia.org/T218690
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Pablo-WMDE
Cc:
Jakob_WMDE added a comment.
**Question**
- should the initial bordered box behave like an actual input field or is it
ok to just look like one (i.e. give it a border)
**Interpretations / assumptions **
- alias editing happens in two stages: showing an "input" with pipes, then
Jakob_WMDE added a comment.
I went through this and thought about some possible edge cases and questions.
- What is the expected backspace behavior? Am I supposed to move to the line
above if I press backspace in an empty alias input field?
- Why arrow-keys for navigation? As far as I
19 matches
Mail list logo
