alaa_wmde added a comment.
@Hanna_Petruschat_WMDE the changes landed on beta now. I checked on
https://m.wikidata.beta.wmflabs.org/wiki/Q11
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
gerritbot added a comment.
Change 543878 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: bump pin
https://gerrit.wikimedia.org/r/543878
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
alaa_wmde added a comment.
thanks @Pablo-WMDE
sorry @Hanna_Petruschat_WMDE apparently I spoke too fast and forgot that
there's another patch needed to get the changes up in beta :/
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
gerritbot added a comment.
Change 543878 had a related patch set uploaded (by Pablo Grass (WMDE); owner:
Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: bump pin
https://gerrit.wikimedia.org/r/543878
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL
Hanna_Petruschat_WMDE added a comment.
Thanks for the update, @alaa_wmde . I'm afraid the vertical spacing is still
not fixed. There is no padding between the last alias of a fingerprint and the
following toggle button.
And I can't find the right ticket for this so I comment here: The
gerritbot added a comment.
Change 542118 **merged** by jenkins-bot:
[wikibase/termbox@master] Add vertical paddings (spacing) between term lists
and toggle buttons
https://gerrit.wikimedia.org/r/542118
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
gerritbot added a comment.
Change 542068 **merged** by jenkins-bot:
[wikibase/termbox@master] Apply white background to input fields in edit mode
https://gerrit.wikimedia.org/r/542068
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
Hanna_Petruschat_WMDE added a comment.
@alaa_wmde
> Let's talk about this one on Monday in person, I don't think I get the
issue yet. Unless you are referring to the vertical spacing maybe? for which
there's a fix in code-review atm.
You are totally right. This was referring to the
alaa_wmde added a comment.
@Hanna_Petruschat_WMDE the non-expandable problem is likely to be the result
of a problem we faced with termbox in production yesterday. Sent out a short
incident report to Wikidata Campsite mailing list.
As for the BG never getting narrower on screens
Hanna_Petruschat_WMDE added a comment.
I just discovered, that in the real mobile Wikidata the styling of the
section "in more languages" already happened but also causes that this section
cannot be expanded. See screenshot below.
F30616015: Screenshot 2019-10-10 at 16.54.30.png
gerritbot added a comment.
Change 542118 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa
Sarhan):
[wikibase/termbox@master] Add vertical paddings (spacing) between term lists
and toggle buttons
https://gerrit.wikimedia.org/r/542118
TASK DETAIL
gerritbot added a comment.
Change 542068 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa
Sarhan):
[wikibase/termbox@master] Apply white background to input fields in edit mode
https://gerrit.wikimedia.org/r/542068
TASK DETAIL
https://phabricator.wikimedia.org/T223452
alaa_wmde added a comment.
@Hanna_Petruschat_WMDE this can be tested on beta now
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: alaa_wmde
Cc: Jakob_WMDE, WMDE-leszek, raja_wmde, Aklapper,
gerritbot added a comment.
Change 541238 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Pull restyling and "fewer languages"
in termbox into Wikibase
https://gerrit.wikimedia.org/r/541238
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
gerritbot added a comment.
Change 541235 **merged** by jenkins-bot:
[wikibase/termbox@master] Expand actions vertically along whole termbox
https://gerrit.wikimedia.org/r/541235
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
Hanna_Petruschat_WMDE added a comment.
Cool. Thanks a lot @alaa_wmde
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: alaa_wmde, Hanna_Petruschat_WMDE
Cc: Jakob_WMDE, WMDE-leszek, raja_wmde,
gerritbot added a comment.
Change 541238 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa
Sarhan):
[mediawiki/extensions/Wikibase@master] Pull restyling and "fewer languages"
in termbox into Wikibase
https://gerrit.wikimedia.org/r/541238
TASK DETAIL
gerritbot added a comment.
Change 541235 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa
Sarhan):
[wikibase/termbox@master] Expand actions vertically along whole termbox
https://gerrit.wikimedia.org/r/541235
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL
alaa_wmde added a comment.
@Hanna_Petruschat_WMDE so it will be easier than I thought and will do it
quickly so that we release it with this change
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
alaa_wmde added a comment.
@Hanna_Petruschat_WMDE right I didn't notice that thanks. I will check how
easy it is to do that and let you know
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
Hanna_Petruschat_WMDE added a comment.
Hi @alaa_wmde! Thaks for bringing this forward. I have a small remark. In the
screenshot, the whole width of the categories have a background color,
including the so called interaction column. In the mock up above you can see
that the right side has a
gerritbot added a comment.
Change 539493 **merged** by jenkins-bot:
[wikibase/termbox@master] Restyle 'In more languages' and 'All entered
languages' sections
https://gerrit.wikimedia.org/r/539493
TASK DETAIL
https://phabricator.wikimedia.org/T223452
EMAIL PREFERENCES
alaa_wmde added a comment.
Discussed @raja_wmde and we agreed for now to apply the padding in the other
way around.
AC would be:
[ ] Content of default languages, in more languages and all entered
lanaguages receive a padding on the left with value of 0.5em on all breakpoints.
alaa_wmde added a comment.
@Hanna_Petruschat_WMDE
Regarding the AC:
> [ ] the background colors have a negative padding of 16px to the left
- this negative padding seem to be needed, esp. with that specific value, for
a certain skin. Where it might not be needed, or value
gerritbot added a comment.
Change 539493 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa
Sarhan):
[wikibase/termbox@master] Restyle 'In more languages' and 'All entered
languages' sections
https://gerrit.wikimedia.org/r/539493
TASK DETAIL
25 matches
Mail list logo
