[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

Rosalie_WMDE added a comment. In T223999#5398932 , @Lydia_Pintscher wrote: > Is there anything needed to be done to get it to work on production? There are some onWiki changes to do. This gist has the diff

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

Lydia_Pintscher added a comment. Is there anything needed to be done to get it to work on production? TASK DETAIL https://phabricator.wikimedia.org/T223999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Lydia_Pintscher Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

gerritbot added a comment. Change 526379 **merged** by jenkins-bot: [mediawiki/extensions/GuidedTour@master] Make the tour steps take action on the page when user does not https://gerrit.wikimedia.org/r/526379 TASK DETAIL https://phabricator.wikimedia.org/T223999 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

Rosalie_WMDE added a comment. Also, the change on github has the double click fixed. TASK DETAIL https://phabricator.wikimedia.org/T223999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE Cc: alaa_wmde, Aklapper, Tarrow, Addshore,

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

Rosalie_WMDE added a comment. Actually the change made onWiki is just 3 lines (2 in MediaWiki:Guidedtour-tour-wbqualifier and 1 in MediaWiki:Guidedtour-lib.js). The rest of the change is in the extension folder, see the change on gerrit above. The github gist

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

gerritbot added a comment. Change 526379 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/GuidedTour@master] Make the tour steps take action on the page when user does not https://gerrit.wikimedia.org/r/526379 TASK

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

alaa_wmde added a comment. > For others to learn more about Wikidata Tours, it would be great to see the code you've changed. With Wikidata Tours being the wiki-specific script this is going to be a bit tricky, but maybe sharing the relevant files as Github gist or something like this would

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

Rosalie_WMDE added a comment. > For others to learn more about Wikidata Tours, it would be great to see the code you've changed. With Wikidata Tours being the wiki-specific script this is going to be a bit tricky, but maybe sharing the relevant files as Github gist or something like this

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

WMDE-leszek added a comment. What I see on the recording is basically what this task describes, great stuff @Rosalie_WMDE ! One think I noticed, that it looks like the "Add qualifier" was clicked twice, i.e. there are two "Property" fields and two "remove" icons. This is due to accidental

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

alaa_wmde added a comment. In T223999#5372150 , @Rosalie_WMDE wrote: > Here is what I have so far. > F29898177: Tours > A short screen record of the tour with expected behaviour

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

Rosalie_WMDE added a comment. Here is what I have so far F29898177: Tours TASK DETAIL https://phabricator.wikimedia.org/T223999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T223999: Wikidata Tours: User can reach a step where the tour popup needs to attach to an element which is not visible

WMDE-leszek added a comment. Tour definition: https://www.wikidata.org/w/index.php?title=MediaWiki:Guidedtour-lib.js TASK DETAIL https://phabricator.wikimedia.org/T223999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Aklapper,