[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

Lydia_Pintscher added a comment. \o/ TASK DETAIL https://phabricator.wikimedia.org/T224189 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lydia_Pintscher Cc: alaa_wmde, WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

gerritbot added a comment. Change 528497 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use thumbnail preferences for thumbnail of Commons media file https://gerrit.wikimedia.org/r/528497 TASK DETAIL https://phabricator.wikimedia.org/T224189 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

Ladsgroup added a comment. In T224189#5398714 , @alaa_wmde wrote: >> One quite expensive way to do this is to define CommonsMedia value type, inject the thumbsize in the value type (by defining CommonsMediaValueParser that takes

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

alaa_wmde added a comment. > One quite expensive way to do this is to define CommonsMedia value type, inject the thumbsize in the value type (by defining CommonsMediaValueParser that takes ParserOptions) and then use it in the CommonsInlineImageFormatter, that would be two days of work at

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

gerritbot added a comment. Change 528497 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Use thumbnail preferences for thumbnail of Commons media file https://gerrit.wikimedia.org/r/528497 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

Ladsgroup added a comment. I got it to work but I could do only by injecting global variables into CommonsInlineImageFormatter, I quite dislike this solution but I couldn't find any way around it that doesn't involve refactoring half of mediawiki core and wikibase. One quite expensive way

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

Ladsgroup added a comment. In T224189#5392838 , @WMDE-leszek wrote: > @Ladsgroup: Have you had a chance to investigate the bypassing the parser cache? Any findings to share? Yes, I'm on it. The main issue is that ParserOptions are

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

WMDE-leszek added a comment. @Ladsgroup: Have you had a chance to investigate the bypassing the parser cache? Any findings to share? TASK DETAIL https://phabricator.wikimedia.org/T224189 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup,

[Wikidata-bugs] [Maniphest] [Commented On] T224189: Use thumbnail preferences for thumbnail of Commons media file

Ladsgroup added a comment. I took a look at this, it's not hard to implement and it doesn't pollute the ParserCache if we get the thumbnail size from ParserOptions. That should be easy. TASK DETAIL https://phabricator.wikimedia.org/T224189 EMAIL PREFERENCES