[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]

2020-02-04 Thread Tgr
Tgr added a comment. In T231084#5839574 , @Addshore wrote: > With canDiffRevisions being implemented in DifferenceEngine which would see if the 2 contents say they can be diffed with each other? How would DifferenceEngine know

[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]

2020-01-30 Thread Addshore
Addshore added a comment. Another option would be something like: $de = $contentHandler->createDifferenceEngine( $form->getContext(), $rev1, $rev2,

[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]

2019-12-16 Thread Ladsgroup
Ladsgroup added a comment. In T231084#5444984 , @Lucas_Werkmeister_WMDE wrote: > On the other hand, other content models sometimes seem to support this – this diff ,