[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]

Tgr added a comment. In T231084#5839574 , @Addshore wrote: > With canDiffRevisions being implemented in DifferenceEngine which would see if the 2 contents say they can be diffed with each other? How would DifferenceEngine know that?

[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]

Addshore added a comment. Another option would be something like: $de = $contentHandler->createDifferenceEngine( $form->getContext(), $rev1, $rev2,

[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]

Ladsgroup added a comment. In T231084#5444984 , @Lucas_Werkmeister_WMDE wrote: > On the other hand, other content models sometimes seem to support this – this diff

[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null

Umherirrender added a comment. Special:ComparePages makes it better https://www.wikidata.org/wiki/Special:ComparePages?page1=&rev1=11&page2=&rev2=772301402&action=&diffonly=&unhide= > Can not diff an entity with a non-entity content. wikibase-non-entity-diff But not the other wa

[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null

Tgr added a comment. In T231084#5554961 , @Tgr wrote: > From a distance, the simple solution would be to create a UserPageError subclass describing the situation and throw that instead of the assertion error. One thing to keep in mi

[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null

Tgr added a comment. The diff logic leaves it to the SlotDiffRenderer implementation to handle incompatible types. Sorry about that, it's a bit shoddy. I don't remember if there was some specific reason for not turning it into a user error, or it was merely rushed. From a distance, the

[Wikidata-bugs] [Maniphest] [Commented On] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null

Lucas_Werkmeister_WMDE added a comment. > TextSlotDiffRenderer->getDiff(Wikibase\ItemContent, WikitextContent) Yeah, diffing item and wikitext contents isn’t going to work… but apparently that’s what this URL is asking for? > index.php?title=Q33232729&curid=34683193&**diff=11&oldid