[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

hashar added a comment. It is definitely gone. Thank you very much! TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle, hashar Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm,

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Yann added a comment.

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

zeljkofilipin added a comment. - The file that caused the error now opens fine: https://commons.wikimedia.org/wiki/File:Bolsonaro_with_Israeli_PM_Benjamin_Netanyahu,_Tel_Aviv,_31_March_2019.jpg - The last occurence of `Revision 363605807 belongs to M77688146 instead of expected M81625979`

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Cparle added a comment. So ... @zeljkofilipin can we close this now? TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21,

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-09-09T12:55:19Z] Synchronized php-1.34.0-wmf.21/extensions/WikibaseMediaInfo/: ubn patch T231276 (duration: 00m 58s) TASK DETAIL https://phabricator.wikimedia.org/T231276

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-09-09T12:51:33Z] Synchronized php-1.34.0-wmf.21/extensions/Wikibase: ubn patch T231276 (duration: 01m 03s) TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 534853 **merged** by Urbanecm: [mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.21] EntityRevisionLookup: specific exception for entity id mismatch https://gerrit.wikimedia.org/r/534853 TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 534854 **merged** by Urbanecm: [mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.21] Entity lookup: mend old ids when loading https://gerrit.wikimedia.org/r/534854 TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 533907 abandoned by Urbanecm: [stopgap] Don't throw an exception on unexpected difference between M* ids Reason: other patch was proposed https://gerrit.wikimedia.org/r/533907 TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Jdforrester-WMF added a comment. Cherry-picked because this is 97% of all fatals in production. I appreciate that this is a bandage and not a fix. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 534854 had a related patch set uploaded (by Jforrester; owner: Pablo Grass (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.21] Entity lookup: mend old ids when loading https://gerrit.wikimedia.org/r/534854 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 534853 had a related patch set uploaded (by Jforrester; owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.21] EntityRevisionLookup: specific exception for entity id mismatch https://gerrit.wikimedia.org/r/534853 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 534218 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Entity lookup: mend old ids when loading https://gerrit.wikimedia.org/r/534218 TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 534216 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] EntityRevisionLookup: specific exception for entity id mismatch https://gerrit.wikimedia.org/r/534216 TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 534216 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] EntityRevisionLookup: specific exception for entity id mismatch https://gerrit.wikimedia.org/r/534216 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 534218 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@master] Entity lookup: mend old ids when loading https://gerrit.wikimedia.org/r/534218 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Urbanecm added a comment. In T231276#5458915 , @Cparle wrote: > @Urbanecm the patch prevents the fatal error, but there are other errors if, for example, a user tries to edit a caption. That's the intention. I want to have it

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Urbanecm added a comment. In T231276#5461117 , @zeljkofilipin wrote: > Lowered priority since it's not blocking the train any more. I raised the priority intentionally above, see history. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Pablo-WMDE added a comment. Just realized this affects the API, when searching via title, as well. e.g. https://commons.wikimedia.org/w/api.php?action=wbgetentities=File:Bolsonaro_with_Israeli_PM_Benjamin_Netanyahu,_Tel_Aviv,_31_March_2019.jpg=commonswiki { "error": {

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Cparle added a comment. @Pablo-WMDE if you change your mind let me know, and I'll fix up the broken unit tests TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle Cc: daniel, Pablo-WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Cparle added a comment. Cool, sounds good to me TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Pablo-WMDE added a comment. @Cparle > AFAICS the introduction of EntityLookup::getEntity() has revealed a problem rather than causing one. The problem is that MediaInfo ids for a slot on a page are based on the id of the page, Well put, no discussion on that. > IMO @Urbanecm

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Cparle added a comment. @Pablo-WMDE this bit of code in WikibaseMediaInfoHooks.php is what triggers the error: $entityId = $this->entityIdFromPageId( $pageId ); $wbRepo = WikibaseRepo::getDefaultInstance(); $entityLookup = $wbRepo->getEntityLookup(); $entity =

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Cparle added a comment. The hook approach doesn't work for MediaInfo, becase the hook doesn't fire if a MediaInfo item doesn't exist for a File page - which it doesn't if no structured data has been added to the page AFAICS the introduction of `EntityLookup::getEntity()` has revealed a

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Urbanecm added a comment. Thanks, running submodule update and composer install. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Urbanecm Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann,

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Pablo-WMDE added a comment. @Urbanecm `ItemId` is a class implemented in the dedicated data-model repository - make sure you have wikibase installed correctly (composer, submodules). TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Urbanecm added a comment. Patch works per @Cparle. I can't test locally due to probably unrelated error: [dd239c1581da0431f6fd1e17] /wiki/Special:Version Error from line 35 of /mnt/c/Users/urban/unsynced/gerrit/mediawiki/extensions/Wikibase/lib/WikibaseLib.entitytypes.php: Class

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Urbanecm added a comment. Thanks @Cparle and @daniel. Fixed my patch. I felt something like that can be necessary, but don't have enough Wikibase knowledge to fully judge. Since I had about 10 spare mins when I thought about writing something to start the work to limit this bug's scope

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

daniel added a comment. In T231276#5458962 , @Cparle wrote: >> The new "actual" ID needs to be forced into the Entity data, I commented on the patch to that effect. > > On @Urbanecm 's patch

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Cparle added a comment. > The new "actual" ID needs to be forced into the Entity data, I commented on the patch to that effect. On @Urbanecm 's patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/533907 ? I don't see a comment (scratches head) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Cparle added a comment. > Maybe it's broken somehow, and every undelete changes the page ID again? Needs investigation, because if that was true, it would greatly aggravate the effect of the MediaInfoID problem. I don't think so - at least locally a delete/restore doesn't change the

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

daniel added a comment. In T231276#5458915 , @Cparle wrote: > @Urbanecm the patch prevents the fatal error, but there are other errors if, for example, a user tries to edit a caption. The new "actual" ID needs to be forced into the

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

daniel added a comment. >> However, this doesn't solve the conceptual problem of breaking all existing references to the old entity ID, internal and external. > > Agreed, but that' longer-term problem. Still high, but not user-facing, at least to viewers. I'd count breaking links as

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Cparle added a comment. @Urbanecm the patch prevents the fatal error, but there are other errors if, for example, a user tries to edit a caption. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Urbanecm added a comment. In T231276#5458493 , @daniel wrote: > Quick fix for the error: just remove the check that triggers the error. Could be converted to a warning, or just a debug message. Good idea, uploaded a patch. >

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

gerritbot added a comment. Change 533907 had a related patch set uploaded (by Urbanecm; owner: Urbanecm): [mediawiki/extensions/Wikibase@master] [stopgap] Don't throw an exception on unexpected difference between M* ids https://gerrit.wikimedia.org/r/533907 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Yann added a comment. In T231276#5458493 , @daniel wrote: > (...)I wonder though why the page ID wasn't restored in this case - I don't really see a reason for that, may be worth investigating. The file is a big file (708.4 MB)

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Cparle added a comment. Not really - the MediaInfo id refers to a slot rather than a page, and isn't accessible via a url. I think the | `ArticleUndelete` solution will work TASK DETAIL https://phabricator.wikimedia.org/T231276

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Lydia_Pintscher added a comment. Not my decision to make but those are presumably stable identifiers that reusers of the data can rely on just like Wikidata Q-IDs for Items. In this case you'll probably want to make the data available under both IDs. Wikidata does this with redirects on

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Mholloway added a comment. Better, if we want to preserve the correspondence between mediainfo IDs and page IDs, would be to hook into ArticleUndelete and update the mediainfo ID if the page ID has changed. (Despite what its

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Mholloway added a comment. What //should// happen here? Should the entity always retain its original ID even after a page move, or should the entity ID always reflect the current page ID of the page with which it's associated? The assumption that the entity ID will always reflect the

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

hashar added a comment. The few errors showing are since 2019-08-26 09:40:00 UTC (there are a few before that). Might just have been an edit on one of the pages that is introduced a fault that is not properly handled. The scope is fairly thin, it just a few items on commonswiki

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Lucas_Werkmeister_WMDE added a comment. In T231276#5441664 , @ArielGlenn wrote: > In T231276#5441586 , @Lucas_Werkmeister_WMDE wrote: > >> > > ... > >> It’s part of the

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

hashar added a comment. Seems that is just a data error with a single entry? I don't feel like this issue should be blocking the train. TASK DETAIL https://phabricator.wikimedia.org/T231276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

ArielGlenn added a comment. In T231276#5441586 , @Lucas_Werkmeister_WMDE wrote: > ... > It’s part of the serialization. Not sure why that would be a new issue, though – this seems like a fairly fundamental issue (tying the

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Lucas_Werkmeister_WMDE added a comment. > but then where does Wikibase(MediaInfo) get the idea that this is the real entity ID of the entity it’s loading from page 81625979? Ah, that’s where: >>> $services = MediaWiki\MediaWikiServices::getInstance(); =>

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Lucas_Werkmeister_WMDE added a comment. I can’t find any trace of this 77688146 ID in production – it’s not a `page_id`, `ar_id`, or `ar_page_id`. I assume it must have been the page ID of the page before it was deleted (and for some reason it was not reused on restore even though it looks

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

ArielGlenn added a comment. https://commons.wikimedia.org/wiki/Special:Log?type===File%3ABolsonaro_with_Israeli_PM_Benjamin_Netanyahu%2C_Tel_Aviv%2C_31_March_2019.jpg== It was deleted and restored on 02:45, 26 Αυγούστου 2019 so I guess something isn't handled quite right in MediaInfo

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

Lucas_Werkmeister_WMDE added a comment. Also, https://commons.wikimedia.org/wiki/Special:EntityData/M77688146 shows another error: > [XWT28gpAAEIAAFLRMGgQ] 2019-08-27 09:25:06: Fatal exception of type "BadMethodCallException" TASK DETAIL https://phabricator.wikimedia.org/T231276