[Wikidata-bugs] [Maniphest] [Commented On] T232214: Undo links disappeared from Wikidata diffs

Lucas_Werkmeister_WMDE added a comment. Undo links are back on Beta Wikidata now (random diff ) TASK DETAIL https://phabricator.wikimedia.org/T232214 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T232214: Undo links disappeared from Wikidata diffs

Lucas_Werkmeister_WMDE added a comment. This probably isn’t serious enough for a backport / Friday deployment, right? I haven’t even seen anyone complain on Project chat yet (which slightly surprises me, to be honest). TASK DETAIL https://phabricator.wikimedia.org/T232214 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232214: Undo links disappeared from Wikidata diffs

gerritbot added a comment. Change 534812 **merged** by jenkins-bot: [mediawiki/core@master] DifferenceEngine: show undo links for non-text content https://gerrit.wikimedia.org/r/534812 TASK DETAIL https://phabricator.wikimedia.org/T232214 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T232214: Undo links disappeared from Wikidata diffs

gerritbot added a comment. Change 534812 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] DifferenceEngine: show undo links for non-text content https://gerrit.wikimedia.org/r/534812 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T232214: Undo links disappeared from Wikidata diffs

Lucas_Werkmeister_WMDE added a comment. In T232214#5471317 , @daniel wrote: > My rationale for suppressing the undo link when direct editing is disabled was that action=edit is for direct editing. > But Wikibase overrides the action

[Wikidata-bugs] [Maniphest] [Commented On] T232214: Undo links disappeared from Wikidata diffs

daniel added a comment. My rationale for suppressing the undo link when direct editing is disabled was that action=edit is for direct editing. But Wikibase overrides the action handle specifically for undos, right? I recall working on that code... That's what I get for lumping this

[Wikidata-bugs] [Maniphest] [Commented On] T232214: Undo links disappeared from Wikidata diffs

Lucas_Werkmeister_WMDE added a comment. > My personal suspect: rMW6906a7728cf5447d30da6c7a51add936f469978a#change-op58PNimx6Sc Can confirm, reverting that commit makes the undo appear