[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-10-30 Thread brennen
brennen added a comment. This remains pretty noisy in production: brennen@mwlog1001:/srv/mw-log$ head -1 error.log

[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-09-24 Thread mmodell
mmodell added a comment. In T233349#5520650 , @Krinkle wrote: > I don't think an extra field is needed because the "error" as reported concept does not have a version. The stack trace is a sample from any of the 100s of instances there

[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-09-24 Thread mmodell
mmodell added a comment. Done: https://gerrit.wikimedia.org/r/c/releng/phatality/+/538947 TASK DETAIL https://phabricator.wikimedia.org/T233349 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Krinkle, Aklapper, mmodell, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-09-24 Thread Krinkle
Krinkle added a comment. I would prefer the stacktrace be unmodified from the original. I don't think an extra field is needed because the "error" as reported concept does not have a version. The stack trace is a sample from any of the 100s of instances there are in Logstash, it may have

[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-09-24 Thread mmodell
mmodell added a comment. @Krinkle I can do that. I mainly cleaned it up to make the stack trace easier to read with the intention of including the version as a separate field. Would you still prefer every line of stack trace to have the long path or would including the version in a

[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-09-24 Thread Krinkle
Krinkle added a comment. @mmodell Can you restore the file paths in the future? This makes it very hard to tell which branch the error happened on, especially around deployments. Ignoring the version for hashing purposes seems fine, but the raw data sent here should be unmodified (except to