Sarai-WMDE added a comment.
I double-checked the styling and it looks very good! As mentioned, I keep
seeing the blue blurred shadow margin on focus state in Chrome: great to hear
this is being tackled! The focus state in your screenshots looks exactly as it
should, @Tarrow. Thanks very
gerritbot added a comment.
Change 569835 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Fix popper button styling
https://gerrit.wikimedia.org/r/569835
TASK DETAIL
https://phabricator.wikimedia.org/T234789
EMAIL PREFERENCES
gerritbot added a comment.
Change 569835 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Fix popper button styling
https://gerrit.wikimedia.org/r/569835
TASK DETAIL
https://phabricator.wikimedia.org/T234789
EMAIL PREFERENCES
Tarrow added a comment.
Hey @Sarai-WMDE,
Just written a patch that isn't yet merged so you won't yet see the effects
on beta
1. I think I've identified that the line-height wasn't being correctly
propagated down to the button label
2. I've adjusted the horizontal padding between
Sarai-WMDE added a comment.
Hello there! Just quickly checked the popper in
https://wikidata.beta.wmflabs.org/wiki/Q535620 and noticed that:
1. The height of the button should be increased to 32px (@size-base; in OOUI)
2. The padding between the button and the label should be 12px
Lydia_Pintscher added a comment.
Just tried this on https://wikidata.beta.wmflabs.org/wiki/Q535620 and the
text isn't updated yet. Just a matter of waiting some more?
TASK DETAIL
https://phabricator.wikimedia.org/T234789
EMAIL PREFERENCES
gerritbot added a comment.
Change 567462 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Update popper text to mention the
new button
https://gerrit.wikimedia.org/r/567462
TASK DETAIL
https://phabricator.wikimedia.org/T234789
EMAIL PREFERENCES
gerritbot added a comment.
Change 567462 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] TR: Update popper text to mention the
new button
https://gerrit.wikimedia.org/r/567462
TASK DETAIL
https://phabricator.wikimedia.org/T234789
gerritbot added a comment.
Change 566319 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Add "remove warning" button to
popper
https://gerrit.wikimedia.org/r/566319
TASK DETAIL
https://phabricator.wikimedia.org/T234789
EMAIL PREFERENCES
gerritbot added a comment.
Change 566319 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] TR: Add "remove warning" button to
popper
https://gerrit.wikimedia.org/r/566319
TASK DETAIL
https://phabricator.wikimedia.org/T234789
EMAIL
Lydia_Pintscher added a comment.
Current state: Sarai is working on new mockup.
TASK DETAIL
https://phabricator.wikimedia.org/T234789
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE, Lydia_Pintscher
Cc: Tarrow, Sarai-WMDE, WMDE-leszek,
WMDE-leszek added a comment.
Change "remove" to "dismiss"
TASK DETAIL
https://phabricator.wikimedia.org/T234789
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: WMDE-leszek
Cc: WMDE-leszek, Jan_Dittrich, Erdinc_Ciftci_WMDE, Aklapper,
12 matches
Mail list logo
