[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

WMDE-leszek added a comment. Many thanks @Anomie for spotting the problem! TASK DETAIL https://phabricator.wikimedia.org/T234795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie, WMDE-leszek Cc: Anomie, Krinkle, aaron, Ladsgroup, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

gerritbot added a comment. Change 541571 **merged** by jenkins-bot: [mediawiki/core@master] Revert "rdbms: optimize insert(), replace(), and upsert() for sqlite when possible" https://gerrit.wikimedia.org/r/541571 TASK DETAIL https://phabricator.wikimedia.org/T234795 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

gerritbot added a comment. Change 541571 had a related patch set uploaded (by Anomie; owner: Anomie): [mediawiki/core@master] Revert "rdbms: optimize insert(), replace(), and upsert() for sqlite when possible" https://gerrit.wikimedia.org/r/541571 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

Anomie added a comment. Bah, I figured it out. I should have read https://www.sqlite.org/lang_UPSERT.html more closely. The diagram at the top shows part of the syntax is optional, but the text adds restrictions: > The syntax that occurs in between the "ON CONFLICT" and "DO" keywords is

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

Krinkle added a comment. @Anomie Ah do you mean php-sqlite3 is not just a driver/client (like for mysql) but actual contains an embedded copy of the lib? If so then yeah, it should indeed behave better. I thought maybe they're separate in which case it's mildly more forgivable to return a

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

Anomie added a comment. But that doesn't change the fact that whatever PHP is using, it reports 3.24.0 but doesn't have the upsert syntax added in 3.24.0. TASK DETAIL https://phabricator.wikimedia.org/T234795 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

Krinkle added a comment. In T234795#5554738 , @WMDE-leszek wrote: > I hacked up DatabaseSqlite to var dump the result of getServerVersion in upsert method calls (https://github.com/manicki/mediawiki/tree/travis-sqlite-debug), and,

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

Anomie added a comment. If it's using 3.22 but reporting 3.24, that would be what's causing the problem here. Or it could just be that the PHP sqlite extension is linked with a different version from the command line client. TASK DETAIL https://phabricator.wikimedia.org/T234795

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

WMDE-leszek added a comment. The last release of sqlite 2.x is from 2005, and don't think Travis even provides a way to use such ancient services. sqlite --version sqlite: command not found I hacked up DatabaseSqlite to var dump the result of getServerVersion in upsert method

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

Ladsgroup added a comment. I have a hypotheses that I haven't tested yet but in bionic if you type "sqlite", you get sqlite2 and if you type "sqlite3", you get v3 (similar to python). Our setting is set to sqlite but I don't if travis take it as 2 or 3. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

WMDE-leszek added a comment. Travis (Bionic used explicitly) reports for `sqlite3 --version` 3.22.0 2018-01-22 18:45:57 0c55d179733b46d8d0ba4d88e01a25e10677046ee3da1d5b1581e86726f2alt1 So it should be following the fallback code path TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

Krinkle added a comment. @Ladsgroup Can you find out which version of sqlite it uses? https://packages.ubuntu.com/bionic/sqlite3 says it comes with 3.22.0, but not sure if it actually uses that plainly on Travis. @Aaron Can you check if this is using the old or new code? If using the

[Wikidata-bugs] [Maniphest] [Commented On] T234795: Wikibase Travis CI jobs failing with the SQL syntax error

Ladsgroup added a comment. Thanks for the note, upgrading to bionic didn't fix it though: https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/594808130 I will look into this more. TASK DETAIL https://phabricator.wikimedia.org/T234795 EMAIL PREFERENCES