[Wikidata-bugs] [Maniphest] [Commented On] T235771: immediate kicking in of the Bridge: Move service creation out of init

gerritbot added a comment. Change 551532 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: move createServices from init to app module https://gerrit.wikimedia.org/r/551532 TASK DETAIL https://phabricator.wikimedia.org/T235771 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T235771: immediate kicking in of the Bridge: Move service creation out of init

gerritbot added a comment. Change 550873 abandoned by Lucas Werkmeister (WMDE): bridge: move service creation from init to app Reason: it looks like there’s general consensus to prefer Id1e6f4c1ce over this https://gerrit.wikimedia.org/r/550873 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235771: immediate kicking in of the Bridge: Move service creation out of init

Lucas_Werkmeister_WMDE added a comment. I uploaded an alternative version of the change. The size changes are exactly the same as in T235771#5666594 , at least when rounded. TASK DETAIL https://phabricator.wikimedia.org/T235771 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235771: immediate kicking in of the Bridge: Move service creation out of init

gerritbot added a comment. Change 551532 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: move createServices from init to app module https://gerrit.wikimedia.org/r/551532 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235771: immediate kicking in of the Bridge: Move service creation out of init

Lucas_Werkmeister_WMDE added a comment. > So after gzip, we almost cut the init module in half (☺) but bloat the app module by more than that amount (☹). It occurred to me that a lot of this might be due to the fact that the init module is more minified than the app module, so here’s

[Wikidata-bugs] [Maniphest] [Commented On] T235771: immediate kicking in of the Bridge: Move service creation out of init

Lucas_Werkmeister_WMDE added a comment. There are a lot of names that //appear// to occur twice or more in our bundles: $ grep _promise-resolve includes-app-after !*** ./node_modules/core-js/library/modules/_promise-resolve.js ***! !***

[Wikidata-bugs] [Maniphest] [Commented On] T235771: immediate kicking in of the Bridge: Move service creation out of init

gerritbot added a comment. Change 550873 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: move service creation from init to app (WIP) https://gerrit.wikimedia.org/r/550873 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235771: immediate kicking in of the Bridge: Move service creation out of init

Lucas_Werkmeister_WMDE added a comment. Okay, with a WIP patch: | file | size before | size after | | - | --- | -- | | `data-bridge.init.js` | 94 kB | 59 kB | | `data-bridge.init.js`