[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

gerritbot added a comment. Change 555462 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove redundant js tests https://gerrit.wikimedia.org/r/555462 TASK DETAIL https://phabricator.wikimedia.org/T237727 EMAIL PREFERENCES https://phabricator.wikimedia.org/setti

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

gerritbot added a comment. Change 555462 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] Remove redundant js tests https://gerrit.wikimedia.org/r/555462 TASK DETAIL https://phabricator.wikimedia.org/T237727 EMAIL PREFERENCES https:/

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

gerritbot added a comment. Change 554538 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Revert "Turn duplicated code into symlinks" https://gerrit.wikimedia.org/r/554538 TASK DETAIL https://phabricator.wikimedia.org/T237727 EMAIL PREFERENCES https://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

gerritbot added a comment. Change 554538 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Revert "Turn duplicated code into symlinks" https://gerrit.wikimedia.org/r/554538 TASK DETAIL https://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Ladsgroup added a comment. I'm fine with copy pasta ^_^ TASK DETAIL https://phabricator.wikimedia.org/T237727 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Addshore, Aklapper, Jakob_WMDE, darthmon_wmde, DannyS712, Nanda

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Addshore added a comment. I guess this one sounds easier? The other option was to keep them copied and make sure they are the same using CI tests. Rather than another submodule.? Thoughts? I guess submodules are actually cheap. On the other hand (OTOH) having the code stay

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Ladsgroup added a comment. I can't find where we documented other options but IIRC. One is the move only four fives to a another submodule and make it another npm module. The other option was to keep them copied and make sure they are the same using CI tests. TASK DETAIL https://phabricato

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Addshore added a comment. git bash = git for windows. Looking at the docs for git for windows the symlink thing is enabled by default. But there are some system etc that this stuff wont work on, or will require you to have admin rights on the system. Also, there are other ways you

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Ladsgroup added a comment. In T237727#5669167 , @Addshore wrote: > I mean, that assumes you use git bash? The setup for picture on the solution I mentioned doesn't mention git bash, it's part of "gitforwindows.org" so I don't think

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Addshore added a comment. I mean, that assumes you use git bash? TASK DETAIL https://phabricator.wikimedia.org/T237727 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Ladsgroup, Addshore, Aklapper, Jakob_WMDE, darthmon_wmde, DannyS712

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Ladsgroup added a comment. We can put it in README TASK DETAIL https://phabricator.wikimedia.org/T237727 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Addshore, Aklapper, Jakob_WMDE, darthmon_wmde, DannyS712, Nandana, L

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Ladsgroup added a comment. https://github.community/t5/How-to-use-Git-and-GitHub/git-bash-symbolic-links-on-windows/td-p/2626 TASK DETAIL https://phabricator.wikimedia.org/T237727 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Lads

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Ladsgroup added a comment. > Possible solution (but sounds pretty terrible) https://stackoverflow.com/questions/5917249/git-symlinks-in-windows That is for 8 years ago. Currently is way better. TASK DETAIL https://phabricator.wikimedia.org/T237727 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T237727: Symlinked js files broken on Windows

Ladsgroup added a comment. When I did the research it said that it handles it properly. Let me get you the documents TASK DETAIL https://phabricator.wikimedia.org/T237727 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Ad