[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-03-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Oh no, wait – if you use the update choice, the error will be the “ambiguous value” bail-out, I suppose. TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-03-09 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I think the discussion we had was only about flashing the normal editing interface again – I at least didn’t expect any error to flash up, and I don’t remember seeing that in my own testing :/ TASK DETAIL https://phabricator.wikimedia.org/T238662

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-03-04 Thread gerritbot
gerritbot added a comment. Change 576063 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: choose strategy based on edit decision https://gerrit.wikimedia.org/r/576063 TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-03-03 Thread gerritbot
gerritbot added a comment. Change 574997 abandoned by Pablo Grass (WMDE): bridge: add update strategy and wire it into save Reason: Will be looted in Idbd7b90e973710a7b5976010568a4b852fcd891a ff. https://gerrit.wikimedia.org/r/574997 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-03-02 Thread gerritbot
gerritbot added a comment. Change 575596 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Add UpdateMutationStrategy https://gerrit.wikimedia.org/r/575596 TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-03-02 Thread gerritbot
gerritbot added a comment. Change 576063 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: choose strategy based on edit decision https://gerrit.wikimedia.org/r/576063 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-03-02 Thread gerritbot
gerritbot added a comment. Change 575596 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Add UpdateMutationStrategy https://gerrit.wikimedia.org/r/575596 TASK DETAIL https://phabricator.wikimedia.org/T238662

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-28 Thread gerritbot
gerritbot added a comment. Change 575218 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: move and rename SnakActionErrors https://gerrit.wikimedia.org/r/575218 TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-28 Thread gerritbot
gerritbot added a comment. Change 575519 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: declare Statement ID as optional https://gerrit.wikimedia.org/r/575519 TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-28 Thread gerritbot
gerritbot added a comment. Change 575519 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: declare Statement ID as optional https://gerrit.wikimedia.org/r/575519 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-28 Thread gerritbot
gerritbot added a comment. Change 573972 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: prepare for different statement mutations https://gerrit.wikimedia.org/r/573972 TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-27 Thread Pablo-WMDE
Pablo-WMDE added a comment. Thought during demo: "value was never correct and has never been" - people with conflicting opinion (think: politics) will most certainly select this option, even though from a technical standpoint we would want them to file a "competing" statement instead. Maybe

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-27 Thread gerritbot
gerritbot added a comment. Change 575218 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: move and rename SnakActionErrors https://gerrit.wikimedia.org/r/575218 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-26 Thread gerritbot
gerritbot added a comment. Change 574997 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: add update strategy and wire it into save https://gerrit.wikimedia.org/r/574997 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-24 Thread gerritbot
gerritbot added a comment. Change 574476 abandoned by Pablo Grass (WMDE): bridge: add update strategy and wire it into save Reason: Will be continued in I6e53f0a378f8835007046da846daeead7e244e6f https://gerrit.wikimedia.org/r/574476 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-24 Thread gerritbot
gerritbot added a comment. Change 574476 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: add update strategy and wire it into save https://gerrit.wikimedia.org/r/574476 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-21 Thread gerritbot
gerritbot added a comment. Change 571553 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: put targetValue into statement only on save https://gerrit.wikimedia.org/r/571553 TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-21 Thread gerritbot
gerritbot added a comment. Change 573972 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] bride: prepare for different statement mutations https://gerrit.wikimedia.org/r/573972 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-13 Thread gerritbot
gerritbot added a comment. Change 571321 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: add targetValue to root state https://gerrit.wikimedia.org/r/571321 TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-11 Thread gerritbot
gerritbot added a comment. Change 571553 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: save targetValue into statement only on save https://gerrit.wikimedia.org/r/571553 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Unassigned myself – anyone is free to pick up #2 and #3. TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-10 Thread gerritbot
gerritbot added a comment. Change 571321 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: add targetValue to root state https://gerrit.wikimedia.org/r/571321 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-10 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. We were unable to find any split more fine-grained than this in the task breakdown: 1. add string value to root store (edit decision is already there) 2. stop updating statements module with every keystroke, move save action to root module, have