[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

Jarekt added a comment. I purged all the files in Category:Pages_with_script_errors and there are no more errors in file namespace. TASK DETAIL https://phabricator.wikimedia.org/T240563 EMAIL PREFERENCES https://phab

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

gerritbot added a comment. Change 558039 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.10] Override getSitelink in mediainfo table, instead of removing it https://gerrit.wikimedia.org/r/558039 TASK DETAIL https://phabricator.wikimedia.org/T240563

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

gerritbot added a comment. Change 558039 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Matthias Mullie): [mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.10] Override getSitelink in mediainfo table, instead of removing it https://gerrit.wikimedia.org/r/558

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

gerritbot added a comment. Change 556981 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Override getSitelink in mediainfo table, instead of removing it https://gerrit.wikimedia.org/r/556981 TASK DETAIL https://phabricator.wikimedia.org/T240563 EMAIL PREFE

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

matthiasmullie added a comment. > Can we just keep `getSitelink` method, and make it return //nil// when applied to MediaInfo entities? Yes - bringing it back as a no-op (for now at least) > The difference between the two files is that the first one has SDC statements and labels and

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

Jarekt added a comment. After my yesterday change to `Module:Wikidata label`, the 30k files affected got fixed. Now the only files in Category:Pages_with_script_errors are couple hundred Gauguin paintings. Lets not "fix"

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

Jarekt added a comment. In T240563#5738558 , @matthiasmullie wrote: > I believe that whatever I ended up doing to remove the `getSitelink` method from MediaInfo entities, accidentally took it away from the parent class as well. Am looki

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

gerritbot added a comment. Change 556981 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie): [mediawiki/extensions/WikibaseMediaInfo@master] Only remove methods in mediainfo table, not in parent wikibase table https://gerrit.wikimedia.org/r/556981 TASK DETAI

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

matthiasmullie added a comment. I believe that whatever I ended up doing to remove the `getSitelink` method from MediaInfo entities, accidentally took it away from the parent class as well. Am looking into it! TASK DETAIL https://phabricator.wikimedia.org/T240563 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

Jarekt added a comment. I "fixed" the immediate line causing errors, and that seems to fix the pages. However the explanation still does not make much sense as the entities the module was operating on were Wikidata entities and not SDC's MediaInfo entities, and we should be able to look up

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

Jarekt added a comment. matthiasmullie and Lucas_Werkmeister_WMDE thanks for reply. I think I understand it now, so in the past we had the code with the same interface, documented in mw:Extension:Wikibase Client/Lua , that suppo

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

matthiasmullie added a comment. Yes, it looks like the removal of `getSitelink` for MediaInfo entities probably caused this. There's already a discussion about this on the module's talk page: https://commons.wikimedia.org/wiki/Module_talk:Wikidata_label#Lua_error_in_Module:Wikidata_label_at

[Wikidata-bugs] [Maniphest] [Commented On] T240563: broken Lua's mw.wikibase.entity:getSitelink function

Lucas_Werkmeister_WMDE added a comment. Module:Wikidata label ’s `getSitelink` function (permalink ) assumes that any entity has a `getSitelink` m