[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-24 Thread Daimona
Daimona added a comment. In T243296#5829712 , @Addshore wrote: > I'm going to go around and update this in various places that it is used. I can help with review. > Also going forward we will consider if we even want this

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Ladsgroup
Ladsgroup added a comment. In T243296#5826271 , @Lucas_Werkmeister_WMDE wrote: > Well, presumably we use WB-CS in more than one repo, so we’d have to duplicate those exclusions again :/ These exclusions are (very likely) technical

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Daimona
Daimona added a comment. Not if we move the main ruleset file per T243296#5826268 . And, of course, unless it turns out to be impossible to have two different rulesets in MW-CS. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Well, presumably we use WB-CS in more than one repo, so we’d have to duplicate those exclusions again :/ TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread thiemowmde
thiemowmde added a comment. There is a .phpcs.xml in Wikibase. You can move the exclusions you want to keep to this file, including the comments explaining them. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Daimona
Daimona added a comment. In T243296#5826260 , @Lucas_Werkmeister_WMDE wrote: > (Unless “Move the WB ruleset to MW-CS” includes disabling those rules for all of MW-CS?) Sort of, yes. I believe it's possible to have two different

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. And how are we going to resolve all the failures we’ll get once we no longer ignore the MW-CS rules that WB-CS currently disables? I think that bullet point is missing from the list above. (Unless “Move the WB ruleset to MW-CS” includes disabling

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Daimona
Daimona added a comment. In T243296#5821602 , @Legoktm wrote: > I think we could ship it inside the MediaWiki-Codesniffer repo so it doesn't fall behind at least. I think this is a great idea to get started with. I guess the plan

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Ladsgroup
Ladsgroup added a comment. I would be in favor of reducing the code base we maintain and reducing the overhead of maintaining those (upgrading libraries, etc.). I say let's ditch it in favor of mediawiki code sniffer. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-21 Thread Legoktm
Legoktm added a comment. If there's still value in having separate Wikibase configuration (I don't think so, but that's just me), then I think we could ship it inside the MediaWiki-Codesniffer repo so it doesn't fall behind at least. TASK DETAIL https://phabricator.wikimedia.org/T243296